Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pie menu for Rhythm Maker #4273

Open
pikurasa opened this issue Jan 14, 2025 · 4 comments
Open

Pie menu for Rhythm Maker #4273

pikurasa opened this issue Jan 14, 2025 · 4 comments

Comments

@pikurasa
Copy link
Collaborator

Based on a discussion we had in our meeting last Sunday, I think we should implement this:

  1. In easy mode, when a user clicks the number section in Rhythm Maker, they should get a pie menu with options 2, 3, and 4.
  2. In advanced mode, when a user clicks the number section in Rhythm Maker, they should get a pie menu with options 2, 3, 4, 5, and 7.

Screenshot of Rhythm Maker widget (the pie menu would initiate by clicking where the "2" is):
Screenshot from 2025-01-14 12-07-00

A user may still type in other values, similar to how you can type other values for note value (although I'm not sure if we want the option to type for mobile).

@AnshuPrajapati29
Copy link

Hi Pikurasa,

I noticed the issue you mentioned regarding the Rhythm Maker in MusicBlocks. While I am still familiarizing myself with this part of the project, I’d love the opportunity to take on this issue and work towards resolving it.

This seems like a great learning opportunity for me as a newcomer to deepen my understanding of the codebase and contribute meaningfully to the project. If you could provide some context or guide me toward relevant resources (e.g., specific files, related modules, or existing documentation), I’d greatly appreciate it.

Please let me know if this works for you or if there’s any specific input you’d like me to consider while working on this.
Looking forward to your thoughts!

Best regards,
Anshu Prajapati

@arjunjayan999
Copy link

Hey @AnshuPrajapati29 , from my current understanding, line 523 of js/widgets/rhythmruler.js handles the input for the dissect number, which sets the number of subdivisions for notes or beats in a bar within the rhythm widget. You can review the pull request submitted by @MostlyKIGuess above your comment. It leverages the Wheelnav.js library to implement the pie menu.

@Sarvesh2783
Copy link
Contributor

I'll work on implementing the pie menu in Rhythm Maker. In easy mode, the options 2, 3, and 4 appear when the user clicks the number section. In advanced mode, I'll enable options 2, 3, 4, 5, and 7. I'll also allow manual entry of other values (as discussed), which might differ between desktop and mobile implementations depending on typing feasibility. And after doing so, will raise a pr shortly.

@MostlyKIGuess
Copy link
Member

I'll work on implementing the pie menu in Rhythm Maker. In easy mode, the options 2, 3, and 4 appear when the user clicks the number section. In advanced mode, I'll enable options 2, 3, 4, 5, and 7. I'll also allow manual entry of other values (as discussed), which might differ between desktop and mobile implementations depending on typing feasibility. And after doing so, will raise a pr shortly.

The pr is already made please check reference

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants