fix: inputs with extends TuiControl has CD problems for writeValue of empty value
#10220
Conversation
Failed tests ❌Before (main) ← Diff → After (local)tests-core-data-list-data-list.pw-DataList-Custom-list-chromium-retry2/01-data-list.diff.png
tests-core-data-list-data-list.pw-DataList-Custom-list-webkit-retry2/01-data-list.diff.png
tests-core-textfield-textf-460ef-vity-on-hover-disable-state-chromium-retry2/textfield-disabled-hover.diff.png
tests-core-textfield-textf-6d0fb-vity-on-hover-invalid-state-chromium-retry2/textfield-invalid-hover.diff.png
tests-core-textfield-textf-df024-ity-on-hover-readonly-state-chromium-retry2/textfield-readonly-hover.diff.png
tests-demo-demo.pw-Demo-components-textfield-chromium-retry2/components-textfield/2.diff.png
tests-demo-demo.pw-Demo-components-textfield-webkit-retry2/components-textfield/2.diff.png
(updated for commit 194d1e0) |
| cy.get('tui-textfield').compareSnapshot({ | ||
| name: 'input-number-write-value-empty-string', | ||
| cypressScreenshotOptions: {padding: 8}, | ||
| }); |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #10220 +/- ##
==========================================
- Coverage 65.78% 65.76% -0.02%
==========================================
Files 1240 1240
Lines 16223 16228 +5
Branches 2309 2310 +1
==========================================
+ Hits 10672 10673 +1
+ Misses 5404 5362 -42
- Partials 147 193 +46
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Visit the preview URL for this PR (updated for commit 194d1e0): https://taiga-previews-demo--pr10220-control-cd-bug-demo-lqztdzzi.web.app (expires Tue, 28 Jan 2025 06:41:06 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 73dddc3c665194f3e11f18c16aeb71af4c289c37 |
BundleMonFiles updated (1)
Unchanged files (4)
Total files change +49B +0.01% Groups updated (1)
Final result: ✅ View report in BundleMon website ➡️ |
nsbarsukov
force-pushed
the
control-cd-bug
branch
from
f2089b5 to
89b0401
Compare
Playwright test results
Details
Failed testschromium › tests/core/data-list/data-list.pw.spec.ts › DataList › Custom list Skipped testswebkit › tests/addon-commerce/input-card-group.pw.spec.ts › InputCardGroup › Examples › input card grouped with validation |
nsbarsukov
requested review from
MarsiBarsi,
waterplea,
vladimirpotekhin and
mdlufy
and removed request for
a team
| protected valueChangeEffect = effect(() => { | ||
| this.onChange(this.unmask(this.masked())); | ||
| // Host binding `host: {'[value]': 'masked()'}` has change detection problem with empty string | ||
| this.render.setProperty(this.el, 'value', this.masked()); |
There was a problem hiding this comment.
Since we only need it for value property we can make it a host directive to hide this hideous logic inside one place, if we cannot figure out why this issue is happening.
nsbarsukov
force-pushed
the
control-cd-bug
branch
from
89b0401 to
194d1e0
Compare
| @@ -24,6 +25,11 @@ export class TuiTextfieldBase<T> implements OnChanges { | |||
| private readonly focused = signal<boolean | null>(null); | |||
|
|
|||
| protected readonly control = inject(NgControl, {optional: true}); | |||
| protected readonly tuiControl = inject(TuiControl, {optional: true}); | |||
| protected readonly empty = computed( | |||
| () => (this.tuiControl?.rawValue() ?? this.value()) === '', | |||
There was a problem hiding this comment.
Yep, it is not reproducible for angular@17
nsbarsukov
changed the title
extends TuiControl has CD problems for writeValue of empty valueextends TuiControl has CD problems for writeValue of empty value
nsbarsukov
changed the title
extends TuiControl has CD problems for writeValue of empty valueextends TuiControl has CD problems for writeValue of empty value
Fixes #10202