-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing element modifier prose-picture
#366
Comments
tordans
changed the title
Missing overwrite
Missing element modifier Dec 5, 2024
prose-picture
prose-picture
Also, just in case someone comes here after using Astros <Picture
src={image}
formats={['png', 'avif']}
class="rounded" // classes on the <img> tag
pictureAttributes={{ class: 'not-prose' }} // classes on the <picture> tag
alt=""
/> |
bmiit145
added a commit
to bmiit145/tailwindcss-typography
that referenced
this issue
Jan 9, 2025
Fixes tailwindlabs#366 Add element modifiers `prose-picture:*` and `prose-images:*` to target `<picture>` and `<img> <picture>` respectively. * Modify `src/index.js` to include element modifiers for `prose-picture:*` and `prose-images:*`. * Update `README.md` to list `prose-picture:*` and `prose-images:*` as available element modifiers. * Add default styles for `prose-picture:*` and `prose-images:*` in `src/styles.js`. * Add tests for the new element modifiers `prose-picture:*` and `prose-images:*` in `src/index.test.js`. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/tailwindlabs/tailwindcss-typography/issues/366?shareId=XXXX-XXXX-XXXX-XXXX).
I have added wait for approval from maintainer |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What version of @tailwindcss/typography are you using?
"@tailwindcss/typography": "^0.5.15",
What version of Node.js are you using?
lts/*
What browser are you using?
Chrome
What operating system are you using?
MacOS
Reproduction repository
Describe your issue
The PR #314 (Issue #144) added default styles to the
<picture>
but there are is no element modifier defined that would allow us to easily change the default styles via classesI suggest to add two modfiers
prose-picture:*
targeting<picture>
prose-images:*
targeting<img> <picture>
Another question that this brings up is, if the
prose-img
modifier should target thepicture>img
element as well. It does ATM https://play.tailwindcss.com/VFWabWBye5 so changing this is likely a breaking change and something to be resolved separately?The text was updated successfully, but these errors were encountered: