🦋 Changeset detected

Latest commit: 5f05c9e

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Are we confident this won't break anything? If this is already handled by the Vite plugin I'm confused that the Sanity plugimns were having trouble

Apart from the react-compiler-runtime PR that fixes a Sanity issue, which this PR will likely break, it shouldn't break any other usecases. I'm happy to look into the Sanity issue if a repro can be shared by them, but at the meantime, I don't think unconditionally adding react-compiler-runtime to optimizeDeps.include is the right solution here.

@stipsan could you share a minimal repro so we can see?

@stipsan could you share a minimal repro so we can see?

Sure, I can find time by end of next week. Is it ok to hold off on reverting the fix until then?

@stipsan Would it be possible to look sooner? This is affecting a lot of users now. Even though it's just a warning message, it's confusing lots of people. We'd like to get this out early next week, so if you could take a look by Monday that would be ideal. It would give a chance to see if there are workarounds that still need to be made. It might need an upstream fix to the Vite plugin, for example.

@stipsan Would it be possible to look sooner? This is affecting a lot of users now. Even though it's just a warning message, it's confusing lots of people. We'd like to get this out early next week, so if you could take a look by Monday that would be ideal. It would give a chance to see if there are workarounds that still need to be made. It might need an upstream fix to the Vite plugin, for example.

Understood 🙌 I'll see if I can find time by end of today!