-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove encryption of empty props to allow server island cacheability #12956
base: main
Are you sure you want to change the base?
Conversation
|
CodSpeed Performance ReportMerging #12956 will not alter performanceComparing Summary
|
@kaytwo your tests are failing, because |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great test, thank you!
Can't really tell from the failures what the problem is with your tests. Looks like the fetches are failing, are you fetching in the same way as the other tests? |
Also this needs a changeset which you can add via |
It's making dev server requests in the build tests, where the dev server isn't running |
Changes
This change removes the encryption of
{}
in the case of a server island with no props. Fixes #12949.Testing
Added two tests: one test that ensures components with props keep getting them re-encrypted, and one where components without props don't have an empty encryption passed through to them.
Docs
Nominally a bugfix, brings the docs mention of caching in line with reality.