Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring PR#114 #125

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Naman-B-Parlecha
Copy link
Contributor

This PR restores the changes from #114 , which was reverted in #124 by @Aditya062003 .

I have reviewed and made the asked changes removing the 5 question limit on each page for MCQ and log messages

@Aditya062003 kindly review and merge

@Aditya062003
Copy link
Contributor

Looks good! Please apply these changes to the web as well. Also, I think this pr #129 addresses the same issue and includes a few additional features. @Roaster05, which one do you think is better?

@Naman-B-Parlecha
Copy link
Contributor Author

Naman-B-Parlecha commented Jan 10, 2025

@Aditya062003 @Roaster05 #129 introduces margins to the PDF pages, but it doesn't address the issue of word overflow. Currently, if the text length exceeds the available space, the words do not break and move to the next line. It would be better to implement a solution that ensures proper word wrapping.

The algorithm I’ve written should handle this properly by ensuring word wrapping is implemented 🙌

@yatikakain
Copy link
Contributor

Hi, I noticed this was about my PR #129 , @Naman-B-Parlecha , thank you for your efforts on this! I just wanted to point out that my PR also addresses the text-wrapping issue to handle word overflow. It’s possible that you may have overlooked this. If there’s something specific in the logic that you think can be improved, I’m open to feedback. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants