Graph Editor: Improve Add Node Workflow #2157
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Allow for creating a node from dragging off of a pin - Filter nodes based on the pinFilterType and the type of the node - Display a label to let the user know a node will be created on mouse release
- used consistent parenthesis
beersandrew
commented
Dec 24, 2024
| @@ -3718,7 +3720,8 @@ void Graph::addNodePopup(bool cursor) | |||
| // Allow spaces to be used to search for node names | |||
| std::replace(subs.begin(), subs.end(), ' ', '_'); | |||
|
|
|||
| if (str.find(subs) != std::string::npos) | |||
| if ((subs.size() == 0 || str.find(subs) != std::string::npos) && | |||
| (_menuFilterType == mx::EMPTY_STRING || node.getType() == _menuFilterType)) | |||
There was a problem hiding this comment.
Is this the correct filtering logic? It does filter properly however I'm not sure this is the right way to filter. Given I'm pulling a pin from a color3 this would:
- Get the
color3type from the_pinFilterType - Assign that type to
_menuFilterType - Filter nodes by that type
This doesn't feel quite right to me since these types seem to be output types rather than input types.
It's unclear to me how to address this as I can imagine, using the same example, you could have many nodes that would have color3 inputs, but what would be the desired behavior in how to link them up, I imagine the first input of the pin type could be matched.
I'll continue down this path to try to filter based on input pin types rather than output types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #1542 . This PR is a draft as I have some open questions remaining, listed below