-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fractal2d
node
#2183
base: main
Are you sure you want to change the base?
Add fractal2d
node
#2183
Conversation
… MDL, along with simple unit tests for coverage - largely just cloning the work done for fractal3d
return float4(c.x, c.y, c.z, a); | ||
} | ||
|
||
// TODO - do we want to rename these to mx_fractal3D_noise_float - if so where else might things need to be updated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That rename sounds logical to me, and I'm CC'ing @krohmerNV for his thoughts from the MDL side.
MDL is broken in this state! |
MaterialX-mdl-fractal2d-node.patch |
I applied the patch provided by @krohmerNV. I didn't realize that we have no MDL evaluation tests in the CI - we should try and work towards fixing that. On the topic of reusing the 3D noise calls to provide the 2D fractal node - If I'm understanding the code - the 3D version is more expensive - so I think maybe it does make sense to keep separate 2D and 3D versions. Certainly I would propose we leave that work to a follow up PR where someone can profile the changes across all the languages and noise types - and in some cases it might be a win - I'm not sure. |
@ld-kerley On MDL code validation using On the proposed change to 3D noise functions, I think Kai is referring to the I think that's a great idea, if you still support the idea of this rename, and it would make this changelist more complete and self-consistent. |
Mirroring the existing behavior for
<fractal3d>
, we add the corresponding<fractal2d> node that uses the
texcoord` input as its manifold.Add support for OSL, MSL, GLSL, MDL (note : MDL not tested).
Updated specification documents to add
<fractal2d>
to the specification and remove it from the proposals document.Also remove
period
inputs for the noises that don't have those inputs in the specification. This is already documented in the proposals document.Note : in the GLSL noise library code I renamed the existing
mx_fractal_noise_xxx()
functions tomx_fractal3d_noise_xxx()
to make the differentiation cleaner with the newmx_fractal2d_noise_xxx()
. But I retained wrapper functions with the old name that just call through to the new name for backwards compatibility. I was unsure how much custom customer code might be referencing those functions. We can remove the shim functions when we have another breaking API release.