Add Value::isEqual to check for data equality #2199
+47
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems like a nice addition to the API to me. |
| @@ -333,6 +333,34 @@ string AggregateValue::getValueString() const | |||
| return result; | |||
| } | |||
|
|
|||
| bool AggregateValue::isEqual(ConstValuePtr other) const | |||
| { | |||
| if (!other->isA<AggregateValue>()) | |||
There was a problem hiding this comment.
This change looks good to me from a high level, and the one issue that I notice is the use of 2-space indentation instead of the 4-space indentation that's standard in our C++ codebase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found the need to compare two mx::ValuePtrs and noticed that there is no straightforward way. Did I overlook something? If not, I'm proposing this helper function.