Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatting Icons #10359

Open
wants to merge 21 commits into
base: master
Choose a base branch
from
Open

Formatting Icons #10359

wants to merge 21 commits into from

Conversation

MEEPofFaith
Copy link
Contributor

@MEEPofFaith MEEPofFaith commented Dec 2, 2024

20241202-023526-java

This method replaces :duo: with the duo icon (and similarly with other content), without the need to check for character id. I originally wanted to override Core.bundle so that I could override get and format to automatically do this to every bundle entry; that way it'd be easier to create bundles and potentially have modded content icon support. However I could not find an easy way to do that, so for now it's just this method.

Currently applied to:

  • Chat
  • Message blocks
  • Hints
  • Objectives

If your pull request is not translation or serverlist-related, read the list of requirements below and check each box:

  • I have read the contribution guidelines.
  • I have ensured that my code compiles, if applicable.
  • I have ensured that any new features in this PR function correctly in-game, if applicable.

@MEEPofFaith
Copy link
Contributor Author

hm what would be the best way to check for the end

@MEEPofFaith
Copy link
Contributor Author

MEEPofFaith commented Dec 2, 2024

image

@MEEPofFaith
Copy link
Contributor Author

Hm but I don't want to have to do two colons every time I want a colon if a string does have an icon in it.

@MEEPofFaith
Copy link
Contributor Author

image
image

@MEEPofFaith MEEPofFaith marked this pull request as ready for review December 2, 2024 21:57
@MEEPofFaith
Copy link
Contributor Author

Where else would it be sensible to throw UI::formatIcons calls?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant