-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Formatting Icons #10359
Open
MEEPofFaith
wants to merge
21
commits into
Anuken:master
Choose a base branch
from
MEEPofFaith:richer-text
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Formatting Icons #10359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hm what would be the best way to check for the end |
Hm but I don't want to have to do two colons every time I want a colon if a string does have an icon in it. |
The hasUnicodeStr already checks for validity
This reverts commit ac660fc.
No longer scans through every character
Where else would it be sensible to throw |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method replaces
:duo:
with the duo icon (and similarly with other content), without the need to check for character id. I originally wanted to overrideCore.bundle
so that I could overrideget
andformat
to automatically do this to every bundle entry; that way it'd be easier to create bundles and potentially have modded content icon support. However I could not find an easy way to do that, so for now it's just this method.Currently applied to:
If your pull request is not translation or serverlist-related, read the list of requirements below and check each box: