why are noisemesh seeds planet id dependent? #10374
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
really awesome installing another mod that happens to add planets only for your planet to look different and have its sector placement and landmarks mismatch
the value added to the actual seed is now a constant 7 (except for 2 colored noisemeshes in which case the color seed has 8 added instead of 7, as in the base game the seed used for the color is planet.id + seed + 1) instead of the planet's id since thats the planet id of most modded planets. this way mods that add only 1 planet dont have to make any changes to keep their planet's appearance
additionally, the makeAsteroid function now has a seed value so that gier, notva and verlius (verilus?) dont look different after this pr since they use noisemeshes
If your pull request is not translation or serverlist-related, read the list of requirements below and check each box: