Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drillEffectChance is actually useful now #10440

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Slotterleet
Copy link
Contributor

I'm certain that this was a genuine typo. updateEffectChance used to be used for determining whether to show drillEffect, as well as updateEffect of drills or not, and drillEffectChance stayed unused for a few years.

If your pull request is not translation or serverlist-related, read the list of requirements below and check each box:

  • I have read the contribution guidelines.
  • I have ensured that my code compiles, if applicable.
  • I have ensured that any new features in this PR function correctly in-game, if applicable.

@Anuken
Copy link
Owner

Anuken commented Jan 21, 2025

drillEffectChance is 1 while updateEffectChance is 0.02, this is a breaking change.

@Slotterleet
Copy link
Contributor Author

While that is a big increase in effects, I think that's fine for slower drills. Maybe lower the drill effect chance for faster drills in particular then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants