Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create bicep-audit.yml #118

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Create bicep-audit.yml #118

wants to merge 3 commits into from

Conversation

tonybaloney
Copy link

Adds automated security testing to all the bicep files in this repository.

I did a manual check and there are some things to review. The results go into the Github Security tab

@yus04
Copy link
Contributor

yus04 commented Jan 10, 2025

PR のワークフローファイルでは、以下リンクの Microsoft の Security DevOps ツールを利用。
https://github.com/microsoft/security-devops-action

ツールを利用することで、セキュリティ分析の結果を GitHub セキュリティタブにアップロード可能。

@yus04
Copy link
Contributor

yus04 commented Jan 10, 2025

(GitHub Actions のワークフローを PR のマージ前に実行・テストすることは難しいため、Fork 先にて以下のテストを実施)

.github/workflows/bicep-audit.yml を追加し、.bicep が拡張子の任意のファイルを追加することで、Validate bicep templates のワークフローが実行されることを確認。
image

bicep ファイルのセキュリティ分析の結果は「Security」タブにて確認できることを確認。
image

@yus04
Copy link
Contributor

yus04 commented Jan 10, 2025

microsoft/security-devops-action@preview から microsoft/security-devops-action@latest に変更しても問題なく動作することを確認。preview よりも latest の方が以降の保守で都合が良いと判断して変更。
image

publisherEmail: publisherEmail
publisherName: publisherName
// Custom properties are not supported for Consumption SKU
customProperties: sku == 'Consumption' ? {} : {

Check failure

Code scanning / templateanalyzer

Use secure ciphers for API Management.

API Management provides support for weak or deprecated ciphers. These older versions are provided for compatibility with clients and backends but are not consider secure. These many of these ciphers are enabled by default and need to be set to 'False'. The following ciphers are considered weak or deprecated: - TripleDes168 - TLS_RSA_WITH_AES_128_CBC_SHA - TLS_RSA_WITH_AES_256_CBC_SHA - TLS_RSA_WITH_AES_128_CBC_SHA256 - TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA - TLS_RSA_WITH_AES_256_CBC_SHA256 - TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA - TLS_RSA_WITH_AES_128_GCM_SHA256.
@yus04 yus04 force-pushed the tonybaloney-patch-1 branch from 3498266 to d2f6b97 Compare January 10, 2025 02:13
@yus04 yus04 requested a review from suzukiyuhsuke January 10, 2025 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants