Fix pylint errors #39397
Open
Fix pylint errors #39397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
API change check APIView has identified API level changes in this PR and created following API reviews. |
l0lawrence
reviewed
Jan 25, 2025
| :param kwargs: Keyword arguments to verify for query_items_change_feed API | ||
| :keyword mode: Must be one of the values in the Enum, 'ChangeFeedMode'. | ||
| :param dict[str, Any] kwargs: Keyword arguments to verify for query_items_change_feed API | ||
| * keyword mode: Must be one of the values in the Enum, 'ChangeFeedMode'. |
| * paramtype is_start_from_beginning: bool | ||
| * keyword start_time: Must be in supported types. | ||
| * paramtype start_time: Union[~datetime.datetime, Literal["Now", "Beginning"]] | ||
| * type kwargs: dict[str, Any] |
| @@ -2780,8 +2782,9 @@ async def __QueryFeed( # pylint: disable=too-many-branches,too-many-statements, | |||
| query: Optional[Union[str, Dict[str, Any]]], | |||
| options: Optional[Mapping[str, Any]] = None, | |||
| partition_key_range_id: Optional[str] = None, | |||
| response_hook: Optional[Callable[[Mapping[str, Any], Mapping[str, Any]], None]] = None, | |||
There was a problem hiding this comment.
this is being changed from a parameter to a kwarg, I want to ensure that this is intended and accurate
| """Get a sorted list of items that were changed, in the order in which they were modified. | ||
|
|
||
| :keyword str continuation: The continuation token retrieved from previous response. It contains chang feed mode. |
There was a problem hiding this comment.
instead of deleting the documentation if you don't want to list out all the args and kwargs for whatever reason could you put a #pylint:disable=the pylint rule on the offending line instead. We dont want to remove documentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Pylint was causing PR build failures. This Fix will fix the pylint errors.
The majority of the errors were caused by
response_hookparameter.response_hookparameter was added to docstrings for number of functions, but none of them were added to the definition of the functions. This caused the docstring and the function definition to be out of sync.The main updates:
response_hookparameter was used inside of the functions, I added the parameter to the function definition.response_hookparameter was not used, I removed the parameter from the docstring.do-not-import-asyncio,do-not-log-exceptions)All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines