Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1st i18n compatible #1000

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

1st i18n compatible #1000

wants to merge 1 commit into from

Conversation

johnfelipe
Copy link

i want to contribute for have this nice and perfect web app with i18n compatible for spanish and italian

@wwwy3y3
Copy link
Member

wwwy3y3 commented Dec 26, 2024

Hi @johnfelipe thanks for the contribution! We'll discuss some implementation details (ex: where we store the preferred language settings ? in db or local storage is fine at early stage?) and get back to you.

I'll add this PR to the open roadmap backlog for now.

@wwwy3y3
Copy link
Member

wwwy3y3 commented Dec 26, 2024

Some suggestions:

  1. If you have any thoughts on how we store the preference, chime in as you want
  2. some files (ex: ejemplo_de_cambio_de_idioma) don't make much sense to me. Seems like misplaced files ?
  3. We're using english for file names & comments, please make sure you align to our coding styles & conventions.
  4. You may want to elaborate more how you want to implement this feature at higher level

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

Successfully merging this pull request may close these issues.

2 participants