Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add electra fork constants to unscheduled networks #7401

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

nflaig
Copy link
Member

@nflaig nflaig commented Jan 26, 2025

This avoids an issue we had previously where configs that extend mainnet preset would inherit wrong parameters. This just ensures this cannot happen in case we those will be forked after mainnet.

@nflaig nflaig requested a review from a team as a code owner January 26, 2025 15:20
Copy link

codecov bot commented Jan 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.60%. Comparing base (cf23839) to head (38804ec).
Report is 1 commits behind head on unstable.

Additional details and impacted files
@@            Coverage Diff            @@
##           unstable    #7401   +/-   ##
=========================================
  Coverage     48.60%   48.60%           
=========================================
  Files           603      603           
  Lines         40523    40523           
  Branches       2070     2070           
=========================================
  Hits          19698    19698           
  Misses        20787    20787           
  Partials         38       38           

@wemeetagain wemeetagain merged commit 5b8e821 into unstable Jan 27, 2025
19 of 20 checks passed
@wemeetagain wemeetagain deleted the nflaig/electra-fork-constants branch January 27, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants