Refactor toml and lock file in cargo parsing using @iarna/toml(#1592)
#1595
Conversation
…oneDX#1592) Signed-off-by: Lizhe Lv <[email protected]>
| // like `libc = 0.2.79` | ||
| version = dependencyNode; | ||
| } else if ( | ||
| Object.prototype.toString.call(dependencyNode) === "[object Object]" |
There was a problem hiding this comment.
Shall we use Object.keys(dependencyNode).length and the existing logic that use instanceOf operator to determine string for consistency?
| Object.prototype.toString.call(dependencyNode) === "[object Object]" | ||
| ) { | ||
| // like `libc = { version = "0.2.79", features = ['rustc-dep-of-std'], default-features = false }` | ||
| version = dependencyNode["version"]; |
There was a problem hiding this comment.
Do we need dependencyNode?.version and dependencyNode?.git here or are those values always present?
There was a problem hiding this comment.
Yes, the value of dependencyNode always present here. But you're right, using dependencyNode?.version can make the code less prone to exceptions.
| // parse `[[package]]` | ||
| if ( | ||
| packageNode && | ||
| Object.prototype.toString.call(packageNode) === "[object Array]" |
There was a problem hiding this comment.
Shall we use Array.isArray here?
There was a problem hiding this comment.
Yes, using Array.isArray would indeed be better here.
|
Looks very good. Just few minor comments. |
| pkg.repository = { url: pkgRepository }; | ||
| } | ||
| if (pkgLicense) { | ||
| pkg.license = pkgLicense; |
There was a problem hiding this comment.
Repotests is complaining about this line. Any ideas?
|
@prabhu Thank you so much for taking the time to review my code and provide such feedback. |
|
Looking forward to the updates. Will be a great improvement. |
No description provided.