Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to Github repo #19

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Add link to Github repo #19

merged 2 commits into from
Sep 26, 2024

Conversation

freshavocado7
Copy link
Contributor

This PR adds a Contribute to GitHub link.

  • Removed "Backend Version" and renamed "Frontend Version" to "Version".
  • Added "Contribute to GitHub" link.
  • Renamed 'SoftwareVersion' to 'AppInfo' for clearer intent and purpose.
  • Fixed a bug where the App information was not visible while no object had been selected.

closes: #6

Copy link
Member

@Wuestengecko Wuestengecko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only two minor things, otherwise LGTM.

frontend/src/components/AppInfo.jsx Outdated Show resolved Hide resolved
frontend/src/components/AppInfo.jsx Outdated Show resolved Hide resolved
<SquareMousePointer
className="ml-1 inline-block h-4 w-4 text-custom-blue"
/>
<SiGithub className="ml-1 inline-block h-4 w-4 text-custom-blue" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do not modify the permitted GitHub logos, including changing the color, […]

-- https://github.com/logos

Let's keep the icon black. I don't want to find out how serious they are about that point.

@Wuestengecko Wuestengecko force-pushed the feat-add-issue-submission branch from f7ef658 to eb10051 Compare September 26, 2024 09:14
@Wuestengecko Wuestengecko changed the title feat: Add link for github page Add link to Github repo Sep 26, 2024
- Remove distinction between backend and frontend version
- Add "Contribute on Github" link
- Rename component from SoftwareVersion to AppInfo for clearer intent
  and purpose
@Wuestengecko Wuestengecko force-pushed the feat-add-issue-submission branch from eb10051 to 338df82 Compare September 26, 2024 09:25
@Wuestengecko Wuestengecko merged commit 91ef007 into master Sep 26, 2024
7 checks passed
@Wuestengecko Wuestengecko deleted the feat-add-issue-submission branch September 26, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add link to "open issue on github"
2 participants