Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dynamic Instrumentation] DEBUG-3364 Add redaction excluded identifiers evironment variable #6581

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

[Dynamic Instrumentation] DEBUG-3364 Add redaction excluded identifiers evironment variable #6581

wants to merge 4 commits into from

Conversation

dudikeleti
Copy link
Contributor

Summary of changes

Now user can add identifiers keywords to exclude them from redaction

@dudikeleti dudikeleti requested a review from a team as a code owner January 22, 2025 10:01
@andrewlock
Copy link
Member

andrewlock commented Jan 22, 2025 •
edited
Loading

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6581) - mean (69ms)  : 66, 71
     .   : milestone, 69,
    master - mean (69ms)  : 67, 71
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (6581) - mean (984ms)  : 957, 1010
     .   : milestone, 984,
    master - mean (983ms)  : 958, 1007
     .   : milestone, 983,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6581) - mean (108ms)  : 106, 110
     .   : milestone, 108,
    master - mean (108ms)  : 106, 110
     .   : milestone, 108,

    section CallTarget+Inlining+NGEN
    This PR (6581) - mean (684ms)  : 669, 698
     .   : milestone, 684,
    master - mean (683ms)  : 665, 700
     .   : milestone, 683,
Loading 
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6581) - mean (91ms)  : 89, 93
     .   : milestone, 91,
    master - mean (91ms)  : 89, 93
     .   : milestone, 91,

    section CallTarget+Inlining+NGEN
    This PR (6581) - mean (637ms)  : 625, 649
     .   : milestone, 637,
    master - mean (637ms)  : 619, 656
     .   : milestone, 637,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6581) - mean (189ms)  : 185, 194
     .   : milestone, 189,
    master - mean (190ms)  : 185, 195
     .   : milestone, 190,

    section CallTarget+Inlining+NGEN
    This PR (6581) - mean (1,087ms)  : 1058, 1116
     .   : milestone, 1087,
    master - mean (1,089ms)  : 1052, 1126
     .   : milestone, 1089,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6581) - mean (276ms)  : 271, 280
     .   : milestone, 276,
    master - mean (276ms)  : 271, 282
     .   : milestone, 276,

    section CallTarget+Inlining+NGEN
    This PR (6581) - mean (872ms)  : 842, 903
     .   : milestone, 872,
    master - mean (873ms)  : 843, 903
     .   : milestone, 873,
Loading 
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6581) - mean (264ms)  : 259, 269
     .   : milestone, 264,
    master - mean (264ms)  : 259, 269
     .   : milestone, 264,

    section CallTarget+Inlining+NGEN
    This PR (6581) - mean (847ms)  : 809, 884
     .   : milestone, 847,
    master - mean (849ms)  : 821, 876
     .   : milestone, 849,
Loading

@andrewlock
Copy link
Member

andrewlock commented Jan 22, 2025 •
edited
Loading

Benchmarks Report for tracer 🐌

Benchmarks for #6581 compared to master:

  • 3 benchmarks are faster, with geometric mean 1.136
  • 1 benchmarks are slower, with geometric mean 1.141
  • All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

  • Mann–Whitney U test with statistical test for significance of 5%
  • Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartStopWithChild net6.0 7.88μs 43.9ns 297ns 0.015 0.0075 0 5.61 KB
master StartStopWithChild netcoreapp3.1 10.2μs 51.6ns 242ns 0.0193 0.00963 0 5.8 KB
master StartStopWithChild net472 16.1μs 53.7ns 208ns 1.04 0.303 0.0957 6.2 KB
#6581 StartStopWithChild net6.0 7.99μs 45.2ns 300ns 0.0166 0.0083 0 5.61 KB
#6581 StartStopWithChild netcoreapp3.1 10.1μs 56.1ns 327ns 0.0152 0.00508 0 5.8 KB
#6581 StartStopWithChild net472 16.3μs 43.2ns 167ns 1.04 0.299 0.097 6.21 KB
Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 485μs 157ns 545ns 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 647μs 452ns 1.69μs 0 0 0 2.7 KB
master WriteAndFlushEnrichedTraces net472 864μs 505ns 1.95μs 0.425 0 0 3.3 KB
#6581 WriteAndFlushEnrichedTraces net6.0 482μs 344ns 1.33μs 0 0 0 2.7 KB
#6581 WriteAndFlushEnrichedTraces netcoreapp3.1 683μs 540ns 2.09μs 0 0 0 2.7 KB
#6581 WriteAndFlushEnrichedTraces net472 842μs 448ns 1.67μs 0.419 0 0 3.3 KB
Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendRequest net6.0 128μs 533ns 2.06μs 0.187 0 0 14.47 KB
master SendRequest netcoreapp3.1 147μs 131ns 492ns 0.216 0 0 17.27 KB
master SendRequest net472 0.01ns 0.00339ns 0.0131ns 0 0 0 0 b
#6581 SendRequest net6.0 129μs 456ns 1.76μs 0.195 0 0 14.48 KB
#6581 SendRequest netcoreapp3.1 148μs 258ns 998ns 0.221 0 0 17.27 KB
#6581 SendRequest net472 0.00687ns 0.00288ns 0.0111ns 0 0 0 0 b
Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master WriteAndFlushEnrichedTraces net6.0 551μs 2.26μs 8.77μs 0.548 0 0 41.77 KB
master WriteAndFlushEnrichedTraces netcoreapp3.1 663μs 3.53μs 18.3μs 0.332 0 0 41.85 KB
master WriteAndFlushEnrichedTraces net472 824μs 3.66μs 14.2μs 8.12 2.44 0.406 53.26 KB
#6581 WriteAndFlushEnrichedTraces net6.0 565μs 3.03μs 15.4μs 0.561 0 0 41.62 KB
#6581 WriteAndFlushEnrichedTraces netcoreapp3.1 656μs 3.55μs 19.4μs 0.326 0 0 41.73 KB
#6581 WriteAndFlushEnrichedTraces net472 847μs 4μs 15.5μs 8.81 2.52 0.419 53.33 KB
Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteNonQuery net6.0 1.38μs 0.823ns 3.19ns 0.0141 0 0 1.02 KB
master ExecuteNonQuery netcoreapp3.1 1.78μs 2.92ns 10.9ns 0.0133 0 0 1.02 KB
master ExecuteNonQuery net472 2.06μs 1.36ns 4.89ns 0.156 0.00103 0 987 B
#6581 ExecuteNonQuery net6.0 1.4μs 0.829ns 3.1ns 0.0147 0 0 1.02 KB
#6581 ExecuteNonQuery netcoreapp3.1 1.76μs 3.33ns 12.9ns 0.0138 0 0 1.02 KB
#6581 ExecuteNonQuery net472 2.09μs 1.65ns 6.38ns 0.157 0.00104 0 987 B
Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master CallElasticsearch net6.0 1.25μs 0.675ns 2.53ns 0.0138 0 0 976 B
master CallElasticsearch netcoreapp3.1 1.64μs 0.841ns 2.92ns 0.0132 0 0 976 B
master CallElasticsearch net472 2.56μs 1.11ns 4.16ns 0.157 0 0 995 B
master CallElasticsearchAsync net6.0 1.31μs 0.601ns 2.25ns 0.0131 0 0 952 B
master CallElasticsearchAsync netcoreapp3.1 1.58μs 1.15ns 4.44ns 0.0133 0 0 1.02 KB
master CallElasticsearchAsync net472 2.62μs 1.08ns 4.05ns 0.167 0 0 1.05 KB
#6581 CallElasticsearch net6.0 1.22μs 0.982ns 3.8ns 0.0134 0 0 976 B
#6581 CallElasticsearch netcoreapp3.1 1.61μs 1.18ns 4.4ns 0.0128 0 0 976 B
#6581 CallElasticsearch net472 2.56μs 1.47ns 5.68ns 0.158 0 0 995 B
#6581 CallElasticsearchAsync net6.0 1.32μs 0.425ns 1.59ns 0.0133 0 0 952 B
#6581 CallElasticsearchAsync netcoreapp3.1 1.57μs 0.428ns 1.54ns 0.0141 0 0 1.02 KB
#6581 CallElasticsearchAsync net472 2.73μs 1.42ns 5.48ns 0.166 0 0 1.05 KB
Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master ExecuteAsync net6.0 1.2μs 0.741ns 2.87ns 0.0134 0 0 952 B
master ExecuteAsync netcoreapp3.1 1.71μs 1.01ns 3.78ns 0.0126 0 0 952 B
master ExecuteAsync net472 1.78μs 0.305ns 1.1ns 0.145 0 0 915 B
#6581 ExecuteAsync net6.0 1.27μs 0.805ns 3.01ns 0.0134 0 0 952 B
#6581 ExecuteAsync netcoreapp3.1 1.69μs 0.712ns 2.67ns 0.0127 0 0 952 B
#6581 ExecuteAsync net472 1.82μs 2.26ns 8.47ns 0.145 0 0 915 B
Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendAsync net6.0 4.18μs 1.36ns 5.1ns 0.0314 0 0 2.31 KB
master SendAsync netcoreapp3.1 5.24μs 2.64ns 9.53ns 0.0364 0 0 2.85 KB
master SendAsync net472 7.38μs 1.68ns 6.52ns 0.494 0 0 3.12 KB
#6581 SendAsync net6.0 4.26μs 1.56ns 5.4ns 0.0321 0 0 2.31 KB
#6581 SendAsync netcoreapp3.1 5.39μs 2.07ns 8ns 0.0379 0 0 2.85 KB
#6581 SendAsync net472 7.36μs 1.53ns 5.94ns 0.494 0 0 3.12 KB
Benchmarks.Trace.ILoggerBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6581

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.ILoggerBenchmark.EnrichedLog‑netcoreapp3.1 1.139 2,408.40 2,114.41

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 1.45μs 0.621ns 2.24ns 0.0233 0 0 1.64 KB
master EnrichedLog netcoreapp3.1 2.41μs 1.28ns 4.96ns 0.0216 0 0 1.64 KB
master EnrichedLog net472 2.5μs 1.26ns 4.88ns 0.25 0 0 1.57 KB
#6581 EnrichedLog net6.0 1.5μs 0.463ns 1.79ns 0.0231 0 0 1.64 KB
#6581 EnrichedLog netcoreapp3.1 2.11μs 3.5ns 13.5ns 0.0222 0 0 1.64 KB
#6581 EnrichedLog net472 2.69μs 0.931ns 3.6ns 0.249 0 0 1.57 KB
Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 116μs 129ns 499ns 0 0 0 4.28 KB
master EnrichedLog netcoreapp3.1 120μs 123ns 461ns 0.0601 0 0 4.28 KB
master EnrichedLog net472 152μs 189ns 733ns 0.682 0.227 0 4.46 KB
#6581 EnrichedLog net6.0 116μs 139ns 501ns 0.0578 0 0 4.28 KB
#6581 EnrichedLog netcoreapp3.1 119μs 104ns 404ns 0 0 0 4.28 KB
#6581 EnrichedLog net472 152μs 143ns 555ns 0.68 0.227 0 4.46 KB
Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 3.08μs 0.764ns 2.86ns 0.0308 0 0 2.2 KB
master EnrichedLog netcoreapp3.1 4.26μs 2.26ns 8.76ns 0.0297 0 0 2.2 KB
master EnrichedLog net472 4.79μs 1.86ns 7.22ns 0.32 0 0 2.02 KB
#6581 EnrichedLog net6.0 3.13μs 1.33ns 5.13ns 0.0297 0 0 2.2 KB
#6581 EnrichedLog netcoreapp3.1 4.19μs 1.32ns 4.95ns 0.0292 0 0 2.2 KB
#6581 EnrichedLog net472 4.91μs 1.3ns 4.86ns 0.32 0 0 2.02 KB
Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master SendReceive net6.0 1.36μs 0.575ns 2.23ns 0.0163 0 0 1.14 KB
master SendReceive netcoreapp3.1 1.81μs 3.43ns 12.8ns 0.015 0 0 1.14 KB
master SendReceive net472 2.06μs 0.783ns 2.82ns 0.183 0 0 1.16 KB
#6581 SendReceive net6.0 1.49μs 0.823ns 3.19ns 0.0164 0 0 1.14 KB
#6581 SendReceive netcoreapp3.1 1.84μs 1.33ns 4.98ns 0.0148 0 0 1.14 KB
#6581 SendReceive net472 2.03μs 1.31ns 5.08ns 0.183 0 0 1.16 KB
Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master EnrichedLog net6.0 2.78μs 3.01ns 11.3ns 0.0223 0 0 1.6 KB
master EnrichedLog netcoreapp3.1 3.86μs 6.13ns 23.7ns 0.0211 0 0 1.65 KB
master EnrichedLog net472 4.35μs 2.39ns 9.24ns 0.323 0 0 2.04 KB
#6581 EnrichedLog net6.0 2.79μs 1.05ns 4.06ns 0.0223 0 0 1.6 KB
#6581 EnrichedLog netcoreapp3.1 3.87μs 2.7ns 10.4ns 0.0215 0 0 1.65 KB
#6581 EnrichedLog net472 4.49μs 2.19ns 8.47ns 0.323 0 0 2.04 KB
Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6581

Benchmark diff/base Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑netcoreapp3.1 1.141 614.57 701.25

Faster 🎉 in #6581

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.SpanBenchmark.StartFinishSpan‑net6.0 1.155 466.99 404.14

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master StartFinishSpan net6.0 467ns 0.582ns 2.25ns 0.00817 0 0 576 B
master StartFinishSpan netcoreapp3.1 613ns 1.03ns 4.01ns 0.0077 0 0 576 B
master StartFinishSpan net472 647ns 1.09ns 4.22ns 0.0916 0 0 578 B
master StartFinishScope net6.0 489ns 0.485ns 1.88ns 0.00966 0 0 696 B
master StartFinishScope netcoreapp3.1 697ns 1.31ns 5.06ns 0.00946 0 0 696 B
master StartFinishScope net472 868ns 1.64ns 6.34ns 0.104 0 0 658 B
#6581 StartFinishSpan net6.0 406ns 1.82ns 7.06ns 0.00804 0 0 576 B
#6581 StartFinishSpan netcoreapp3.1 700ns 0.597ns 2.23ns 0.00777 0 0 576 B
#6581 StartFinishSpan net472 637ns 0.909ns 3.52ns 0.0917 0 0 578 B
#6581 StartFinishScope net6.0 520ns 0.786ns 3.04ns 0.00974 0 0 696 B
#6581 StartFinishScope netcoreapp3.1 759ns 1.09ns 4.24ns 0.00943 0 0 696 B
#6581 StartFinishScope net472 860ns 1.51ns 5.86ns 0.104 0 0 658 B
Benchmarks.Trace.TraceAnnotationsBenchmark - Faster 🎉 Same allocations ✔️

Faster 🎉 in #6581

Benchmark base/diff Base Median (ns) Diff Median (ns) Modality
Benchmarks.Trace.TraceAnnotationsBenchmark.RunOnMethodBegin‑net6.0 1.114 690.10 619.29

Raw results

Branch Method Toolchain Mean StdError StdDev Gen 0 Gen 1 Gen 2 Allocated
master RunOnMethodBegin net6.0 693ns 1.63ns 6.31ns 0.00976 0 0 696 B
master RunOnMethodBegin netcoreapp3.1 910ns 1.74ns 6.73ns 0.00905 0 0 696 B
master RunOnMethodBegin net472 1.04μs 3.03ns 11.7ns 0.104 0 0 658 B
#6581 RunOnMethodBegin net6.0 619ns 0.44ns 1.7ns 0.00966 0 0 696 B
#6581 RunOnMethodBegin netcoreapp3.1 966ns 0.366ns 1.42ns 0.0095 0 0 696 B
#6581 RunOnMethodBegin net472 1.09μs 0.147ns 0.569ns 0.104 0 0 658 B

@datadog-ddstaging
Copy link

datadog-ddstaging bot commented Jan 22, 2025 •
edited
Loading

Datadog Report

Branch report: dudik/add-redaction-excluded-ev
Commit report: 82e3c4d
Test service: dd-trace-dotnet

❌ 15 Failed (0 Known Flaky), 234513 Passed, 2827 Skipped, 32h 35m 18.97s Total Time

❌ Failed Tests (15)

This report shows up to 5 failed tests.

  • AllConfigurationValuesAreRegisteredWithIntake - Datadog.Trace.Tests.Telemetry.ConfigurationTests - Details

    Expand for error 
     Expected keysWithoutConfig.OrderBy(x => x) to be empty because Keys should be listed in config_norm_rules or block_prefixes, but found at least one item {"DD_DYNAMIC_INSTRUMENTATION_REDACTION_EXCLUDED_IDENTIFIERS"}.

  • AllConfigurationValuesAreRegisteredWithIntake - Datadog.Trace.Tests.Telemetry.ConfigurationTests - Details

    Expand for error 
     Expected collection to be empty because Keys should be listed in config_norm_rules or block_prefixes, but found at least one item {"DD_DYNAMIC_INSTRUMENTATION_REDACTION_EXCLUDED_IDENTIFIERS"}.

  • AllConfigurationValuesAreRegisteredWithIntake - Datadog.Trace.Tests.Telemetry.ConfigurationTests - Details

    Expand for error 
     Expected keysWithoutConfig.OrderBy(x => x) to be empty because Keys should be listed in config_norm_rules or block_prefixes, but found at least one item {"DD_DYNAMIC_INSTRUMENTATION_REDACTION_EXCLUDED_IDENTIFIERS"}.

  • AllConfigurationValuesAreRegisteredWithIntake - Datadog.Trace.Tests.Telemetry.ConfigurationTests - Details

    Expand for error 
     Expected collection to be empty because Keys should be listed in config_norm_rules or block_prefixes, but found at least one item {"DD_DYNAMIC_INSTRUMENTATION_REDACTION_EXCLUDED_IDENTIFIERS"}.

  • AllConfigurationValuesAreRegisteredWithIntake - Datadog.Trace.Tests.Telemetry.ConfigurationTests - Details

    Expand for error 
     Expected keysWithoutConfig.OrderBy(x => x) to be empty because Keys should be listed in config_norm_rules or block_prefixes, but found at least one item {"DD_DYNAMIC_INSTRUMENTATION_REDACTION_EXCLUDED_IDENTIFIERS"}.

GreenMatan
GreenMatan approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@GreenMatan GreenMatan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left couple of comments

tracer/src/Datadog.Trace/Configuration/ConfigurationKeys.Debugger.cs Show resolved Hide resolved
tracer/src/Datadog.Trace/Debugger/Snapshots/Redaction.cs Show resolved Hide resolved
@dudikeleti dudikeleti force-pushed the dudik/add-redaction-excluded-ev branch from 2b26bc0 to 82e3c4d Compare January 22, 2025 14:57
@dudikeleti dudikeleti force-pushed the dudik/add-redaction-excluded-ev branch from 82e3c4d to 0f9fe5f Compare January 23, 2025 11:44
@dudikeleti dudikeleti requested a review from a team as a code owner January 23, 2025 11:44
@datadog-ddstaging
Copy link

Datadog Report

Branch report: dudik/add-redaction-excluded-ev
Commit report: 0f9fe5f
Test service: dd-trace-dotnet

❌ 70 Failed (0 Known Flaky), 252685 Passed, 2925 Skipped, 32h 36m 28.94s Total Time

❌ Failed Tests (70)

This report shows up to 5 failed tests.

  • IntegrationDisabled - Datadog.Trace.ClrProfiler.IntegrationTests.AdoNet.MicrosoftDataSqlClientTests - Details

    Expand for error 
     Expected exit code: 0, actual exit code: 134.

  • SubmitsTraces - Datadog.Trace.ClrProfiler.IntegrationTests.AdoNet.MicrosoftDataSqlClientTests - Details

    Expand for error 
     Expected exit code: 0, actual exit code: 134.

  • SubmitsTraces - Datadog.Trace.ClrProfiler.IntegrationTests.AdoNet.MicrosoftDataSqlClientTests - Details

    Expand for error 
     Expected exit code: 0, actual exit code: 134.

  • SubmitsTraces - Datadog.Trace.ClrProfiler.IntegrationTests.AdoNet.MicrosoftDataSqlClientTests - Details

    Expand for error 
     Expected exit code: 0, actual exit code: 134.

  • SubmitsTraces - Datadog.Trace.ClrProfiler.IntegrationTests.AdoNet.MicrosoftDataSqlClientTests - Details

    Expand for error 
     Expected exit code: 0, actual exit code: 134.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GreenMatan GreenMatan GreenMatan approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area:debugger
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dudikeleti @andrewlock @GreenMatan