-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add process_cpu_seconds_total to kube_apiserver_metrics check #19415
Add process_cpu_seconds_total to kube_apiserver_metrics check #19415
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good, but please add the new metric to the metadata.csv file somewhere
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
kube_apiserver_metrics/datadog_checks/kube_apiserver_metrics/kube_apiserver_metrics.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
small nits on the metrics name remapping.
also can be good to add the metrics to the Out of the box dashboard https://github.com/DataDog/integrations-core/blob/master/kube_apiserver_metrics/assets/dashboards/overview.json
(can be done in a next PR)
57f3af2
to
40c286b
Compare
What does this PR do?
This PR adds
process_cpu_seconds_total
to the list of metrics collected by the kube_apiserver_metrics check and remaps it toprocess_cpu_total
Motivation
GitHub issue: #18219
QA
Tested with a custom built datadog-agent container that includes this change.
Review checklist (to be filled by reviewers)
qa/skip-qa
label if the PR doesn't need to be tested during QA.backport/<branch-name>
label to the PR and it will automatically open a backport PR once this one is merged