Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: io-ts-bignumber package #218

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SHaTRO
Copy link

@SHaTRO SHaTRO commented Dec 8, 2022

Adding base-10 BigNumber codecs using the "bignumber.js" package.

Adding base-10 BigNumber codecs using the "bignumber.js" package.
@EricCrosson
Copy link
Owner

Hi @SHaTRO, thank you for this PR! I can see you've put a high degree of thought and detail into this implementation. I think this is a useful package.

My only concern is the placement of io-ts-bignumber inside numbers-ts. Now that I think harder about the scope of this repository, I quite like that it includes only JavaScript-native number types (bigint, number).

My concern with including a third-party number type that I'm not personally familiar with is I suspect I would flounder when it comes to maintenance. I'm not familiar with the release cycle of bignumber.js, or how well it adheres to semantic versioning. I have the strong impression that I would not be the best maintainer of io-ts-bignumber in terms of stability provided to its users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants