Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BibTeX citation box (#1325) #3718

Merged
merged 8 commits into from
Nov 10, 2024
Merged

Add BibTeX citation box (#1325) #3718

merged 8 commits into from
Nov 10, 2024

Conversation

nrllh
Copy link
Collaborator

@nrllh nrllh commented Aug 9, 2024

Implemented a citation box in BibTeX format as per the discussion in this issue: #1325

Implemented a citation box in BibTeX format as per the discussion in issue #1325. Details: #1325
@tunetheweb tunetheweb added the development Building the Almanac tech stack label Aug 21, 2024
Fixing fff issue from linter.
@mgifford
Copy link
Contributor

The linter is pointing to problems in this:

.citation-box pre {
padding: 16px;
border: 1px solid #e0e0e0;
border-radius: 4px;
background-color: #ffffff;
box-shadow: 0 1px 3px rgba(0, 0, 0, 0.1);
margin-bottom: 20px;
font-family: monospace;
background-color: #f9f9f9;
overflow-x: auto;
white-space: pre-wrap; /* Allow wrapping of long lines */
margin: 0;
}

Both different use of background-color and also margin-bottom & bottom.

Not sure what it should be. I suspect we could just delete:
background-color: #ffffff;
margin-bottom: 20px;

1 similar comment
@mgifford
Copy link
Contributor

The linter is pointing to problems in this:

.citation-box pre {
padding: 16px;
border: 1px solid #e0e0e0;
border-radius: 4px;
background-color: #ffffff;
box-shadow: 0 1px 3px rgba(0, 0, 0, 0.1);
margin-bottom: 20px;
font-family: monospace;
background-color: #f9f9f9;
overflow-x: auto;
white-space: pre-wrap; /* Allow wrapping of long lines */
margin: 0;
}

Both different use of background-color and also margin-bottom & bottom.

Not sure what it should be. I suspect we could just delete:
background-color: #ffffff;
margin-bottom: 20px;

@nrllh nrllh self-assigned this Oct 15, 2024
@tunetheweb tunetheweb merged commit 673a3ea into main Nov 10, 2024
6 checks passed
@tunetheweb tunetheweb deleted the bibtex-citation-box branch November 10, 2024 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development Building the Almanac tech stack
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants