Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security 2024 Chapter #3816

Merged
merged 35 commits into from
Nov 11, 2024
Merged

Security 2024 Chapter #3816

merged 35 commits into from
Nov 11, 2024

Conversation

GJFR
Copy link
Member

@GJFR GJFR commented Oct 28, 2024

@tunetheweb tunetheweb added the writing Related to wording and content label Oct 28, 2024
src/content/en/2024/security.md Outdated Show resolved Hide resolved
src/content/en/2024/security.md Outdated Show resolved Hide resolved
src/content/en/2024/security.md Outdated Show resolved Hide resolved
src/content/en/2024/security.md Outdated Show resolved Hide resolved
@GJFR
Copy link
Member Author

GJFR commented Nov 9, 2024

@tunetheweb, is there a way to refer to figures in the text?

It seems [Figure 17](#fig-17) is not a valid link.

@tunetheweb
Copy link
Member

That should work. Won’t work in markdown as the link won’t exist but will work fine for that reason chapter.

Just be careful if you add or remove figures and change the numbering. So that’s why we normally just say “the previous figure shows…” or link to headings. But there are a few instances of direct figure link too.

@tunetheweb
Copy link
Member

tunetheweb commented Nov 9, 2024

Ah I see you need to add linting overrides to prventing linking errors when linking figures. Added in c351b25

@GJFR
Copy link
Member Author

GJFR commented Nov 10, 2024

@tunetheweb: All TODOs are resolved, except the one in Vik's bio (tagging @vikvanderlinden).

Everything else should be OK, but unfortunately we didn't have an editor go over the text. I did a quick pass just now and could fix some minor issues.

@GJFR GJFR marked this pull request as ready for review November 10, 2024 16:28
@tunetheweb
Copy link
Member

I'm gonna merge this so it makes the initial launch. May do another editing pass afterwards.

@tunetheweb tunetheweb merged commit bd306c3 into HTTPArchive:main Nov 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
writing Related to wording and content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Security 2024
3 participants