This repository has been archived by the owner on Jun 27, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Known issues:
This PR is to discuss the issues. Do not merge until resolved.
Problem: If we use the
ValueResourceParser
and parse the processedvalues.xml
file, which is generated by the build process, then there are no comments, the get eaten.Possible solution: we need to parse the untouched xml files (
strings.xml
, ...) to get the comments/documentation...Original
strings.xml
:Processed/generated
values.xml
:Additional todos:
<!-- <string name="disabled_string">...</string> -->
should be ignored and not seen as documentation