-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only add symbols that are explicit entrypoints when building juliac image #56681
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! I like this version much better
Thanks @gbaraldi 👍
Is it possible to add #56603 as a test? |
Co-authored-by: Cody Tapscott <[email protected]>
Test failed seems related.
|
I pushed a version that should work. However there still seems to be a bug with const_return ccallables; including |
This is only needed because `jl_reinit_ccallable` looks at method metadata that trimming will normally remove for const_api code.
OK I fixed that and added a test. But, we could ignore this whole situation entirely by skipping |
This currently just does a linear search over the items. We might want to change this datastructure to a hash table at some point, but given that I don't think libraries have too too many entrypoints this linear search should be fast enough.