Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make TransformBy generic #733

Merged
merged 10 commits into from
Jan 16, 2025
Merged

Make TransformBy generic #733

merged 10 commits into from
Jan 16, 2025

Conversation

benjamaan476
Copy link
Contributor

@benjamaan476 benjamaan476 commented Jan 16, 2025

Had to force the name of the TransformBy struct to make openapi linting happy. Can now use TranformBy generically with Point3d<f32>, Point3d<LengthUnit> and Point4d

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@e4a7772). Learn more about missing BASE report.

Files with missing lines Patch % Lines
modeling-cmds/src/shared.rs 0.00% 13 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #733   +/-   ##
=======================================
  Coverage        ?   25.23%           
=======================================
  Files           ?       35           
  Lines           ?     2104           
  Branches        ?        0           
=======================================
  Hits            ?      531           
  Misses          ?     1573           
  Partials        ?        0           
Flag Coverage Δ
unittests 25.23% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

modeling-cmds/src/shared.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@adamchalmers adamchalmers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's the OpenAPI schema your engine PR produces:

Screenshot 2025-01-16 at 9 43 16 AM

I don't think this #[serde(rename)] fix is going to actually produce a correct schema. It seems that the schema requires TransformBy to use T = Point3d.

@benjamaan476 benjamaan476 merged commit e92c4f8 into main Jan 16, 2025
7 checks passed
@benjamaan476 benjamaan476 deleted the ben/transform_length_unit branch January 16, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants