Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editorial change: fix anchor to Components.securitySchemes #4282

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Editorial change: fix anchor to Components.securitySchemes #4282

merged 1 commit into from
Jan 10, 2025

Conversation

char0n
Copy link
Contributor

@char0n char0n commented Dec 27, 2024

The anchor is pointing to Security Scheme Object definition instead of Components.securitySchemes

@char0n char0n requested review from a team as code owners December 27, 2024 14:01
ralfhandl
ralfhandl requested changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@ralfhandl ralfhandl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@char0n Thanks for catching this unintended duplicate anchor!

Unfortunately this means that some of the references to this anchor need to be changed to still point here, most likely all except the ones in this line.

@char0n char0n force-pushed the char0n/fix-components-security-schemes-anchor branch from 05884de to 6dc216c Compare January 3, 2025 11:51
@char0n char0n force-pushed the char0n/fix-components-security-schemes-anchor branch from 6dc216c to 1e0fd70 Compare January 3, 2025 11:55
@char0n
Copy link
Contributor Author

char0n commented Jan 3, 2025

@ralfhandl thanks. Amended all appropriate references.

@ralfhandl ralfhandl merged commit 0178e80 into OAI:v3.1-dev Jan 10, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Facebook575 Facebook575 Facebook575 approved these changes

@handrews handrews handrews approved these changes

@ralfhandl ralfhandl ralfhandl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@char0n @ralfhandl @handrews @Facebook575