Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional fields for the tag object #4288

Open
wants to merge 4 commits into
base: v3.2-dev
Choose a base branch
from

Conversation

lornajane
Copy link
Contributor

Implementation of the proposal to extend the functionality offered by tags. The main features:

  • tags get a summary field in addition to their description
  • tags can have a parent tag, enabling building a tree-ish hierarchy
  • tags can have a kind to say what sort of tag they are, so we can use tags for many; Add tag kinds registry to the spec site #4287 adds a registry for the most common types

Pull request still in draft because I would like to link to the registry but it doesn't exist yet so we should not merge - review feedback very welcome though!

src/oas.md Outdated Show resolved Hide resolved
miqui
miqui previously approved these changes Jan 9, 2025
@karenetheridge
Copy link
Member

Love this. As an implementor, the first thing that comes to mind is "now I need to write an interface "get me a list of all the operations with a particular tag kind".

mikekistler
mikekistler previously approved these changes Jan 9, 2025
Copy link
Contributor

@mikekistler mikekistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

src/oas.md Show resolved Hide resolved
@karenetheridge
Copy link
Member

karenetheridge commented Jan 9, 2025

  • Schema changes are required for this PR and are not done yet

@lornajane lornajane dismissed stale reviews from mikekistler and miqui via a055eca January 10, 2025 12:19
@lornajane lornajane marked this pull request as ready for review January 10, 2025 12:23
@lornajane lornajane requested review from a team as code owners January 10, 2025 12:23
mikekistler
mikekistler previously approved these changes Jan 10, 2025
Copy link
Contributor

@mikekistler mikekistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 👍

I left a couple minor comments but nothing serious enough to block merging.

src/oas.md Outdated Show resolved Hide resolved
| <a name="tag-description"></a>description | `string` | A description for the tag. [CommonMark syntax](https://spec.commonmark.org/) MAY be used for rich text representation. |
| <a name="tag-external-docs"></a>externalDocs | [External Documentation Object](#external-documentation-object) | Additional external documentation for this tag. |
| <a name="tag-parent"></a>parent | `string` | The `name` of a tag that this tags is nested under. The named tag MUST exist in the API description, and circular references between parent and child tags MUST NOT be used. |
| <a name="tag-kind"></a>kind | `string` | A machine-readable string to categorize what sort of tag it is. Any string value can be used; common uses are `nav` for Navigation, `badge` for visible badges, `audience` for APIs used by different groups. A [registry of the most commonly used values](https://spec.openapis.org/registry/tag-kind/) is available. |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does "machine-readable" add anything here? Isn't the entire description machine readable? It's a minor point but it might raise doubts for some readers.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it because it makes clear that this field is not intended for prose text.

Co-authored-by: Mike Kistler <[email protected]>
@ralfhandl ralfhandl requested review from a team and removed request for baywet January 10, 2025 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants