-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional fields for the tag object #4288
base: v3.2-dev
Are you sure you want to change the base?
Conversation
Love this. As an implementor, the first thing that comes to mind is "now I need to write an interface "get me a list of all the operations with a particular tag kind". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 👍
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 👍
I left a couple minor comments but nothing serious enough to block merging.
| <a name="tag-description"></a>description | `string` | A description for the tag. [CommonMark syntax](https://spec.commonmark.org/) MAY be used for rich text representation. | | ||
| <a name="tag-external-docs"></a>externalDocs | [External Documentation Object](#external-documentation-object) | Additional external documentation for this tag. | | ||
| <a name="tag-parent"></a>parent | `string` | The `name` of a tag that this tags is nested under. The named tag MUST exist in the API description, and circular references between parent and child tags MUST NOT be used. | | ||
| <a name="tag-kind"></a>kind | `string` | A machine-readable string to categorize what sort of tag it is. Any string value can be used; common uses are `nav` for Navigation, `badge` for visible badges, `audience` for APIs used by different groups. A [registry of the most commonly used values](https://spec.openapis.org/registry/tag-kind/) is available. | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does "machine-readable" add anything here? Isn't the entire description machine readable? It's a minor point but it might raise doubts for some readers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like it because it makes clear that this field is not intended for prose text.
Co-authored-by: Mike Kistler <[email protected]>
Implementation of the proposal to extend the functionality offered by tags. The main features:
summary
field in addition to their descriptionkind
to say what sort of tag they are, so we can use tags for many; Add tag kinds registry to the spec site #4287 adds a registry for the most common typesPull request still in draft because I would like to link to the registry but it doesn't exist yet so we should not merge - review feedback very welcome though!