-
Notifications
You must be signed in to change notification settings - Fork 809
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement New toolkit version csharp samples #1422
Conversation
@@ -89,11 +103,11 @@ Modify the `appsettings.json` file with the following details: | |||
- Update configuration with the ```MicrosoftAppId```, ```MicrosoftAppPassword``` and ```MicrosoftAppTenantId``` values received while doing Microsoft Entra ID app registration in your Azure portal. | |||
- Press `F5` to run the project | |||
|
|||
1) Modify the `manifest.json` in the `/AppManifest` folder | |||
1) Modify the `manifest.json` in the `/appPackage` folder | |||
Replace the following details: | |||
- `<<Your Microsoft App Id>>` with your MicrosoftAppId received after doing Microsoft Entra ID app registration in your Azure portal. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You may need to also update the variable names
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have updated the below as per your comments.
{{AAD_APP_CLIENT_ID}}
{{BOT_DOMAIN}}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The env variable name is not critical issue, you can update in next PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks correct, Approving!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good !
Sample List -
app-checkin-location/csharp
app-installation-using-qr-code/csharp
bot-proactive-messaging/csharp
bot-release-management/csharp
graph-bulk-meetings/csharp