-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
End to End kyma test for node and maven #285
base: main
Are you sure you want to change the base?
Conversation
@MrShubham22 please send the secret to me via Teams |
done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
2 things from my side:
Lots of redundancies between the Node and Java scripts. Have you thought about reusing common parts? See e.g. how CF deployment reuses code through actions.
Lots of lengthy 'progress log', which should be avoided. Especially docker
, and curl
cause this. Check for options in these tools that hide progress output. I have done this already for mvn
via its -B
parameter.
Sure will look into that , Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, from testing perspective. Please see Christian's comments.
tried moving the common docker login and setting up env part of a diff workflow but docker login and kubeconfig export and whatever setup we do , the context of it gets lost when we come back to the called workflow and based on that login and kubeconfig exported file we're pushing images. |
also yes i'm looking for -quiet verbose for the cli commands wehrever possible |
DOCKER_PASSWORD github secret in this repo needs to be changed for the e2e tests to work