Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

End to End kyma test for node and maven #285

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Conversation

MrShubham22
Copy link

@MrShubham22 MrShubham22 commented Sep 15, 2022

DOCKER_PASSWORD github secret in this repo needs to be changed for the e2e tests to work

@cla-assistant
Copy link

cla-assistant bot commented Sep 15, 2022

CLA assistant check
All committers have signed the CLA.

@MrShubham22 MrShubham22 requested a review from chgeo September 21, 2022 07:49
@chgeo
Copy link
Member

chgeo commented Sep 21, 2022

@MrShubham22 please send the secret to me via Teams

@MrShubham22
Copy link
Author

@MrShubham22 please send the secret to me via Teams

done

Copy link
Member

@chgeo chgeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 things from my side:

Lots of redundancies between the Node and Java scripts. Have you thought about reusing common parts? See e.g. how CF deployment reuses code through actions.

Lots of lengthy 'progress log', which should be avoided. Especially docker, and curl cause this. Check for options in these tools that hide progress output. I have done this already for mvn via its -B parameter.

@MrShubham22
Copy link
Author

MrShubham22 commented Sep 22, 2022

2 things from my side:

Lots of redundancies between the Node and Java scripts. Have you thought about reusing common parts? See e.g. how CF deployment reuses code through actions.

Lots of lengthy 'progress log', which should be avoided. Especially docker, and curl cause this. Check for options in these tools that hide progress output. I have done this already for mvn via its -B parameter.

Sure will look into that , Thanks

Copy link
Contributor

@uwe-klinger uwe-klinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, from testing perspective. Please see Christian's comments.

@MrShubham22
Copy link
Author

2 things from my side:

Lots of redundancies between the Node and Java scripts. Have you thought about reusing common parts? See e.g. how CF deployment reuses code through actions.

Lots of lengthy 'progress log', which should be avoided. Especially docker, and curl cause this. Check for options in these tools that hide progress output. I have done this already for mvn via its -B parameter.

tried moving the common docker login and setting up env part of a diff workflow but docker login and kubeconfig export and whatever setup we do , the context of it gets lost when we come back to the called workflow and based on that login and kubeconfig exported file we're pushing images.

@MrShubham22
Copy link
Author

2 things from my side:

Lots of redundancies between the Node and Java scripts. Have you thought about reusing common parts? See e.g. how CF deployment reuses code through actions.

Lots of lengthy 'progress log', which should be avoided. Especially docker, and curl cause this. Check for options in these tools that hide progress output. I have done this already for mvn via its -B parameter.

also yes i'm looking for -quiet verbose for the cli commands wehrever possible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants