Add basic {% doc %} tag parsing support #621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesmengo
force-pushed
the
jm/doc_tag
branch
2 times, most recently
from
bdfdee9 to
9f70770
Compare
jamesmengo
force-pushed
the
jm/doc_tag
branch
3 times, most recently
from
31923d9 to
c2768ee
Compare
This stack of pull requests is managed by Graphite. Learn more about stacking. |
jamesmengo
force-pushed
the
jm/doc_tag
branch
from
c2768ee to
a6b207d
Compare
This was referenced Dec 3, 2024
jamesmengo
changed the title
jamesmengo
force-pushed
the
jm/doc_tag
branch
2 times, most recently
from
8e2f374 to
d1954f6
Compare
jamesmengo
force-pushed
the
jm/doc_tag
branch
from
d1954f6 to
1afd9de
Compare
jamesmengo
force-pushed
the
jm/doc_tag
branch
from
1afd9de to
b09fec0
Compare
charlespwd
reviewed
Dec 3, 2024
Comment on lines
+629
to
+652
| liquidDoc: { | ||
| type: ConcreteNodeTypes.LiquidRawTag, | ||
| name: 'doc', | ||
| body: (tokens: Node[]) => tokens[1].sourceString, | ||
| children: (tokens: Node[]) => { | ||
| const contentNode = tokens[1]; | ||
| return toLiquidDocAST( | ||
| source, | ||
| contentNode.sourceString, | ||
| offset + contentNode.source.startIdx, | ||
| ); | ||
| }, | ||
| whitespaceStart: (tokens: Node[]) => tokens[0].children[1].sourceString, | ||
| whitespaceEnd: (tokens: Node[]) => tokens[0].children[7].sourceString, | ||
| delimiterWhitespaceStart: (tokens: Node[]) => tokens[2].children[1].sourceString, | ||
| delimiterWhitespaceEnd: (tokens: Node[]) => tokens[2].children[7].sourceString, | ||
| locStart, | ||
| locEnd, | ||
| source, | ||
| blockStartLocStart: (tokens: Node[]) => tokens[0].source.startIdx, | ||
| blockStartLocEnd: (tokens: Node[]) => tokens[0].source.endIdx, | ||
| blockEndLocStart: (tokens: Node[]) => tokens[2].source.startIdx, | ||
| blockEndLocEnd: (tokens: Node[]) => tokens[2].source.endIdx, | ||
| }, |
There was a problem hiding this comment.
I think this needs an override for {% liquid %}. If not in this PR, it should be created as an issue.
There was a problem hiding this comment.
jamesmengo
force-pushed
the
jm/doc_tag
branch
from
b09fec0 to
450083b
Compare
2 tasks
jamesmengo
force-pushed
the
jm/doc_tag
branch
from
450083b to
330b509
Compare
charlespwd
reviewed
Dec 4, 2024
| */ | ||
| function toLiquidDocAST(source: string, matchingSource: string, offset: number) { | ||
| // When we switch parser, our locStart and locEnd functions must account | ||
| // for the offset of the {% liquid %} markup |
There was a problem hiding this comment.
my bad copy paste, this should say doc :)
charlespwd
approved these changes
Dec 4, 2024
Add stage-2 ast tests for doc tags
jamesmengo
force-pushed
the
jm/doc_tag
branch
from
330b509 to
59c43dc
Compare
This was referenced Dec 5, 2024
This was referenced Jan 7, 2025
This was referenced Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are you adding in this PR?
https://github.com/Shopify/develop-advanced-edits/issues/441
Adds support for Liquid doc tags (
{% doc %}) in the LiquidHTML parser.This is the basic implementation which we will iterate on.
What's next? Any followup issues?
What did you learn?
Before you deploy
changeset<- waiting until we built on top of this to add a changeset