get rid of observer_cruise in observer_service code

[wintonzheng]

Important

Renames observer_cruise to observer_task in observer_service.py and adds ObserverCruiseNotFound exception for missing tasks.

• Behavior:
  • Renames observer_cruise to observer_task in run_observer_cruise, run_observer_cruise_helper, and related functions in observer_service.py.
  • Introduces ObserverCruiseNotFound exception in exceptions.py to handle missing observer tasks.
• Functions:
  • Updates return type of run_observer_cruise and mark_observer_cruise_as_failed to ObserverTask.
  • Modifies _summarize_observer_cruise to return ObserverTask.
• Misc:
  • Adjusts logging and error handling to reflect the renaming changes.

^{This description was created by for 0dfd4fe. It will automatically update as commits are pushed.}

[ellipsis-dev]

👍 Looks good to me! Reviewed everything up to 0dfd4fe in 14 seconds

More details

• Looked at 423 lines of code in 2 files
• Skipped 0 files when reviewing.
• Skipped posting 1 drafted comments based on config settings.

1. skyvern/exceptions.py:578

• Draft comment:
  Consider renaming observer_cruise_id to observer_task_id in the exception message for consistency with the rest of the code changes.
• Reason this comment was not posted:
  Confidence changes required: 50%
  The PR aims to replace 'observer_cruise' with 'observer_task' in the observer_service code. However, the exception class 'ObserverCruiseNotFound' still uses 'observer_cruise_id' in its message, which should be updated to 'observer_task_id' for consistency.

Workflow ID: wflow_qDnuSqwJmQlPHHzZ

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

[ellipsis-dev]

👍 Looks good to me! Incremental review on 0dfd4fe in 32 seconds

More details

• Looked at 423 lines of code in 2 files
• Skipped 0 files when reviewing.
• Skipped posting 1 drafted comments based on config settings.

1. skyvern/exceptions.py:576

• Draft comment:
  Consider renaming ObserverCruiseNotFound to ObserverTaskNotFound for consistency with the rest of the code changes.
• Reason this comment was not posted:
  Decided after close inspection that this draft comment was likely wrong and/or not actionable:
  The comment has a point - the error message uses "Observer task" not "Observer cruise". However, I don't have enough context about what an "observer cruise" vs "observer task" is. The class name may be intentionally using "cruise" to refer to a specific type of task. Without understanding the domain model, I can't be confident this rename would be correct.
  I may be being too cautious - the error message clearly uses "task" which suggests the code author themselves thinks of this as a task. The inconsistency between message and class name could indicate a real issue.
  While the message uses "task", I still can't be certain that "cruise" isn't the correct domain term. Making assumptions about domain terminology without full context is risky.
  Without more context about what "observer cruise" means in this codebase, I cannot confidently say whether this rename would be correct, despite the inconsistent terminology in the error message.

Workflow ID: wflow_JhbV4k5fRVnit22w

---

You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.