Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: introduce @validate_body_root_model #423

Merged
merged 5 commits into from
Sep 27, 2024

Conversation

leafty
Copy link
Member

@leafty leafty commented Sep 23, 2024

Add @validate_body_root_model which is a drop-in replacement for Sanic's @validate when validating a RootModel or a model deriving from it.

The decorator should be replaced by @validate once sanic-org/sanic-ext#198 is fixed.

/deploy

@leafty leafty changed the title fix: introduce @validate_body_root_model() refactor: introduce @validate_body_root_model() Sep 23, 2024
@leafty leafty changed the title refactor: introduce @validate_body_root_model() refactor: introduce @validate_body_root_model Sep 23, 2024
@coveralls
Copy link

coveralls commented Sep 23, 2024

Pull Request Test Coverage Report for Build 11066173668

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 34 of 34 (100.0%) changed or added relevant lines in 5 files are covered.
  • 2 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.04%) to 90.441%

Files with Coverage Reduction New Missed Lines %
components/renku_data_services/storage/blueprints.py 1 94.76%
components/renku_data_services/users/db.py 1 94.18%
Totals Coverage Status
Change from base Build 11033349401: 0.04%
Covered Lines: 9338
Relevant Lines: 10325

💛 - Coveralls

@RenkuBot
Copy link
Contributor

You can access the deployment of this PR at https://renku-ci-ds-423.dev.renku.ch

@leafty leafty marked this pull request as ready for review September 24, 2024 07:08
@leafty leafty requested a review from a team as a code owner September 24, 2024 07:08
Copy link
Member

@Panaetius Panaetius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for this!

I have two bugfix PRs open in sanic (one addresses this issue) for over a month now, without any reply. So don't have too high hopes of them fixing this any time soon on their end...

@leafty leafty enabled auto-merge (squash) September 27, 2024 07:11
@leafty leafty merged commit 63b22b2 into main Sep 27, 2024
13 of 14 checks passed
@leafty leafty deleted the leafty/fix-validate-body-root-model branch September 27, 2024 07:37
@RenkuBot
Copy link
Contributor

Tearing down the temporary RenkuLab deplyoment for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants