Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add alert with details component #76

Merged
merged 6 commits into from
Jan 7, 2025
Merged

Add alert with details component #76

merged 6 commits into from
Jan 7, 2025

Conversation

vitPinchuk
Copy link
Contributor

@vitPinchuk vitPinchuk commented Jan 7, 2025

Add alert box component
need for: 213

Screenshot 2025-01-07 at 17 00 20 Screenshot 2025-01-07 at 17 00 25

@vitPinchuk vitPinchuk self-assigned this Jan 7, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.36%. Comparing base (6e3f595) to head (c5323e1).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #76      +/-   ##
==========================================
+ Coverage   78.22%   78.36%   +0.14%     
==========================================
  Files          69       71       +2     
  Lines        2181     2196      +15     
  Branches      522      548      +26     
==========================================
+ Hits         1706     1721      +15     
+ Misses        473      416      -57     
- Partials        2       59      +57     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vitPinchuk vitPinchuk changed the title Add alert box component Add alert with details component Jan 7, 2025
Copy link
Collaborator

@asimonok asimonok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
Components version 3.9.0 is published

@mikhail-vl ready for review

@mikhail-vl mikhail-vl added the enhancement New feature or request label Jan 7, 2025
@mikhail-vl mikhail-vl added this to the Components 3.9.0 milestone Jan 7, 2025
Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl mikhail-vl merged commit fe9432f into main Jan 7, 2025
1 check passed
@mikhail-vl mikhail-vl deleted the feat/alert-box branch January 7, 2025 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants