Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add npm package to import xlsx format correctly #233

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

vitPinchuk
Copy link
Contributor

Resolves: #64

@vitPinchuk vitPinchuk self-assigned this Jan 24, 2025
@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.83%. Comparing base (fd3ad78) to head (9235816).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #233   +/-   ##
=======================================
  Coverage   99.83%   99.83%           
=======================================
  Files         189      189           
  Lines        3048     3067   +19     
  Branches      707      708    +1     
=======================================
+ Hits         3043     3062   +19     
  Misses          5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vitPinchuk vitPinchuk requested review from asimonok and mikhail-vl and removed request for asimonok January 24, 2025 12:13
Copy link
Contributor

@asimonok asimonok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl ready for review

@mikhail-vl mikhail-vl added the enhancement New feature or request label Jan 24, 2025
export const downloadXlsx = (content: unknown[][], fileName = 'download') => {
const ws = utils.aoa_to_sheet(content);
const wb = utils.book_new();
utils.book_append_sheet(wb, ws, 'Sheet1');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use table tab name here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

@vitPinchuk vitPinchuk requested a review from mikhail-vl January 24, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: In review
Development

Successfully merging this pull request may close these issues.

Add download settings
4 participants