-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add npm package to import xlsx format correctly #233
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #233 +/- ##
=======================================
Coverage 99.83% 99.83%
=======================================
Files 189 189
Lines 3048 3067 +19
Branches 707 708 +1
=======================================
+ Hits 3043 3062 +19
Misses 5 5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
@mikhail-vl ready for review
src/utils/file.ts
Outdated
export const downloadXlsx = (content: unknown[][], fileName = 'download') => { | ||
const ws = utils.aoa_to_sheet(content); | ||
const wb = utils.book_new(); | ||
utils.book_append_sheet(wb, ws, 'Sheet1'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use table tab name here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
Resolves: #64