Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update external resources usage #384

Merged
merged 3 commits into from
Jan 9, 2025
Merged

Conversation

vitPinchuk
Copy link
Contributor

Resolves: #383

@vitPinchuk vitPinchuk self-assigned this Dec 28, 2024
Copy link

codecov bot commented Dec 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.71%. Comparing base (e437cf2) to head (67551db).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #384   +/-   ##
=======================================
  Coverage   98.70%   98.71%           
=======================================
  Files          41       41           
  Lines         620      621    +1     
  Branches       98       90    -8     
=======================================
+ Hits          612      613    +1     
  Misses          8        8           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@asimonok asimonok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl ready for review

@mikhail-vl mikhail-vl added the enhancement New feature or request label Jan 8, 2025
@mikhail-vl mikhail-vl added this to the Text 5.7.0 milestone Jan 8, 2025
@mikhail-vl mikhail-vl changed the title Update externalResources usage Update external resources usage Jan 9, 2025
Copy link
Member

@mikhail-vl mikhail-vl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@mikhail-vl mikhail-vl merged commit f836225 into main Jan 9, 2025
5 checks passed
@mikhail-vl mikhail-vl deleted the feat/endless-call-to-resources branch January 9, 2025 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Self-hosted CSS is reloaded in endless loop starting with version 5.5.0
3 participants