Modify spec to use Promise.resolve on result of call to suspending function. #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syg
reviewed
Jan 22, 2025
| 1. Otherwise, if [=list/size=] of |ret| is 1 and [$IsPromise$](|ret|.\[[Value]][0]): | ||
| 1. Let |promise| be |ret|.\[[Value]][0]. | ||
| 1. Otherwise, | ||
| 1. Let |promise| be [=?=] [$PromiseResolve$]({{%Promise%}},|ret|.\[[Value]]). |
There was a problem hiding this comment.
The ? macro here is incorrect because it would propagate a throw completion to the caller, which in this case is Wasm. You should use [$Completion$](PromiseResolve(...)) and do the manual checking, coercion of the exception, and [=WebAssembly/Throw=] like done elsewhere in this algorithm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the specification:
All calls to functions that are marked as Suspending will be processed using Promise.resolve.
Note that, if the callee throws, then that throw is NOT converted to a Promise. In part, this is because we cannot reliably invoke Promise.reject in all cases (e.g., stack overflow errors).