Add test for pwrite with append flag #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've filed an issue with the WasmEdge team. They have expressed desire to bring WasmEdge behavior in line with Wasmtime and add this test case. |
WASI specifies `fd_pwrite` to be similar to [POSIX `pwritev`][1] which specifies that it should ignore the append flag and write from the supplied offset. Currently, only Wasmtime implements this behavior. NB: There is a documented [Linux bug][2] that pwrite does not respect the offset and instead appends. Wasmtime fixes this by tracking the append flag status and hiding it from the OS. [1]: https://pubs.opengroup.org/onlinepubs/9699919799/functions/write.html [2]: https://linux.die.net/man/2/pwrite
|
Thanks, the test looks reasonable. Could you please fix formatting problems reported by the build? |
|
@loganek Thanks! Fixed format. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WASI specifies
fd_pwriteto be similar to POSIXpwritevwhich specifies that it should ignore the append flag and write from the supplied offset. Currently, only Wasmtime implements this behavior.NB: There is a documented Linux bug that pwrite does not respect the offset and instead appends. Wasmtime fixes this by tracking the append flag status and hiding it from the OS.