Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update uuid to v10 #910

Closed
wants to merge 3 commits into from
Closed

fix: update uuid to v10 #910

wants to merge 3 commits into from

Conversation

aminya
Copy link

@aminya aminya commented Sep 16, 2021 •
edited
Loading

Closes #859
Closes #858

@aminya aminya requested a review from a team as a code owner September 16, 2021 10:25
@aminya aminya requested a review from a team September 16, 2021 10:25
@yaananth yaananth removed the request for review from a team February 10, 2022 14:07
@BrettDong BrettDong mentioned this pull request Mar 26, 2023
Closed
@aminya aminya requested review from a team as code owners August 18, 2024 08:36
@aminya aminya changed the title fix: update uuid to v8 fix: update uuid to v10 Aug 19, 2024
@iamstarkov
Copy link

iamstarkov commented Oct 29, 2024 •
edited
Loading

node now ships uuid v4 by itself (Added in: v15.6.0, v14.17.0)
https://nodejs.org/docs/latest/api/crypto.html#cryptorandomuuidoptions

const crypto = require('node:crypto');
const uuid = crypto.randomUUID();

@joshmgross
Copy link
Member

Thank you for your contribution!

uuid is being removed in #1824 as part of #925, so this is no longer necessary.

@joshmgross joshmgross closed this Oct 30, 2024
Liabaemt
Liabaemt reviewed Oct 31, 2024
View reviewed changes
Copy link

@Liabaemt Liabaemt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Run fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Liabaemt Liabaemt Liabaemt left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aminya @iamstarkov @joshmgross @Liabaemt