Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch over password strength coloration to named Tailwind colors + test update #1101

Open
2 tasks done
andrewtavis opened this issue Jan 21, 2025 · 6 comments
Open
2 tasks done
Labels
feature New feature or request help wanted Extra attention is needed

Comments

@andrewtavis
Copy link
Member

Terms

Description

Along with #1099 where we're updating the i18n strings within the end to end tests, we also want to make sure that other variables can be loaded in so that we don't fail tests if they're changed. Another place where this could be improved is in the tests for the password strength indicator. This is using the hard coded strings with the hex colors found in frontend/components/indicator/IndicatorPasswordStrength.vue. The e2e tests for this component can be found in frontend/test-e2e/component-objects/PasswordStrength.ts. It would be best if these colors were added to the frontend/assets/css/tailwind.css file such that their tests can be rewritten to use their variable names.

Contribution

Happy to support someone with this and review when a PR is opened!

CC @cquinn540 who's working on the e2e tests ✅

@andrewtavis andrewtavis added feature New feature or request help wanted Extra attention is needed labels Jan 21, 2025
@fowlerztwitch
Copy link

fowlerztwitch commented Jan 25, 2025

Hey @andrewtavis, I have modified the code in this branch to perform tests based on named colors. However, I am not sure what the full extent of this issue should be.

  1. Do you want a refactor of the handling of the colors in the frontend as well as in the tests?
  2. If not, do you mean that you want the test to compute the colors in the pre-existing hardcoded configuration of the frontend and compare them to the named colors newly declared ?

_1) is easy to do, 2) would require a bit more thinking but can be done as well. I am just asking because I want to be sure what is the way you want to go.

Best regards,
Fowlerz

@Remyc0des
Copy link

Hey @andrewtavis can I work on this?

@fowlerztwitch
Copy link

Hey @Remyc0des, I have already tried an implementation (to be completed) of this issue. Can I get your opinion on it? (See link to my branch in my previous comment) I'm taking the opportunity to learn step by step new techs through issues such as this one so if you could give a look at my code it'd be great

@andrewtavis
Copy link
Member Author

Long day of calls so far, @fowlerztwitch :) I'll take a look at your fork soon, but also feel free to open a PR with what you have as that will get it a little bit more in my direct line of sight. Thanks for your work so far!

Thanks also for the interest in helping, @Remyc0des!

@Remyc0des
Copy link

@fowlerztwitch yeah ill take a look at it right now thank you!

@andrewtavis
Copy link
Member Author

Thanks for the support, @Remyc0des :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request help wanted Extra attention is needed
Projects
Status: Todo
Development

No branches or pull requests

3 participants