-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/add named colors #1106
base: main
Are you sure you want to change the base?
Feat/add named colors #1106
Conversation
Thank you for the pull request!The activist team will do our best to address your contribution as soon as we can. The following is a checklist for maintainers to make sure this process goes as well as possible. Feel free to address the points below yourself in further commits if you realize that actions are needed :) If you're not already a member of our public Matrix community, please consider joining! We'd suggest using Element as your Matrix client, and definitely join the General and Development rooms once you're in. Also consider joining our bi-weekly Saturday dev syncs. It'd be great to have you! Maintainer checklist
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First PR Commit Check
- The commit messages for the remote branch of a new contributor should be checked to make sure their email is set up correctly so that they receive credit for their contribution
- The contributor's name and icon in remote commits should be the same as what appears in the PR
- If there's a mismatch, the contributor needs to make sure that the email they use for GitHub matches what they have for
git config user.email
in their local activist repo (can be set withgit config --global user.email "GITHUB_EMAIL"
)
✅ Deploy Preview for activist-org ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
To update on my PR, I have checked through the Netlify deploy preview the errors appearing on my end :
|
Contributor checklist
Description
This pull request implements two changes :
This was put through the whole test process documented in the CONTRIBUTING.md file. The End2End tests were performed locally and it is important to note that some tests failed (tests on aspects not modified in this PR). Here are the tests that failed :
Sign-in page : Page shows error for invalid credentials > The screenshot given by the playwright report shows a user logged-in page so I would expect this to be a db / backend issue in my configuration which has nothing to do with the changes implemented in this PR.
Landing Page : User can request access > No modification to the landing page was done.
It is also important to note that the 'yarn format' command for Prettier did not modify any file and gave some warnings. Using yarn format --write modified all files from CRLF to LF. Another commit for linting to transition from CRLF to LF can be added if requested.
Related issue