AYS-660 | Change Error Code and Message for Already Passive Users #436

egehanasal · 2025-01-23T00:56:23Z

Checklist

Before submitting your pull request, ensure the following:

Title and Branch Naming Conventions:
- The pull request title follows the
  standard: Pull Request Naming Conventions.
- The branch name follows one of the conventions outlined in
  the Branch Naming Conventions.
Local Testing:
- I have tested my changes locally on Postman, and they are working as expected.
Code Quality:
- The code is formatted according to the project's coding guidelines and style.
- The code has been reviewed to ensure its quality.
- The code does not contain any issues flagged by SonarLint.
Documentation:
- Necessary documentation has been added or existing documentation has been updated, specifically detailing changes made in Postman.
Testing:
- Relevant unit tests have been written and included.
- Relevant integration tests have been written and included.
Reviewers and Assignees:
- Default reviewers have been assigned to this pull request.
- Assignees have been added if necessary.
Labels and Associations:
- No specific actions are required in the Labels and Associations section for this pull request.

…Has Been Changed

…-user-not-active-error-code

src/main/java/org/ays/auth/exception/AysUserAlreadyPassiveException.java

src/main/java/org/ays/auth/exception/AysUserNotActiveAuthException.java

src/main/java/org/ays/auth/exception/AysUserNotActiveException.java

agitrubard · 2025-01-26T11:02:35Z

src/test/java/org/ays/auth/controller/AysUserEndToEndTest.java

+        Assertions.assertEquals(AysUserStatus.PASSIVE, userFromDatabase.get().getStatus());
+        Assertions.assertNull(userFromDatabase.get().getUpdatedUser());
+    }
+


Diğer senaryo için de end-to-end test ekleyebilir miyiz?

ayrıca bu senaryoda da en sondaki assertnull satırının doğru çalıştığından emin miyiz? findbyid metodu updated alanı null ise created ile aynı alanı dönüyor gözlemlediğim kadarıyla, bu sebeple bende şu an assertnull hata veriyor. @agitrubard @egehanasal

Evet bu test basari ile geciyor. Testin basinda kullanici olusturdugumuz ve sonrasinda bir degisiklik yapmadigimiz icin, userFromDatabase'de ilgili alanlar bu sekilde geliyorlar

Kullanicinin state'inin degismedigini gozlemlemek adina testin son satirina o kontrolu eklemenin onemli oldugunu dusundum

@egehanasal buraya updatedAt alanını da ekleyebiliriz ✅

src/test/java/org/ays/auth/controller/AysUserEndToEndTest.java

src/test/java/org/ays/auth/service/impl/AysUserUpdateServiceImplTest.java

agitrubard · 2025-01-27T18:05:42Z

src/test/java/org/ays/auth/controller/AysUserEndToEndTest.java

+        Assertions.assertEquals(AysUserStatus.PASSIVE, userFromDatabase.get().getStatus());
+        Assertions.assertNull(userFromDatabase.get().getUpdatedUser());
+    }
+


@egehanasal buraya updatedAt alanını da ekleyebiliriz ✅

agitrubard · 2025-01-27T18:12:38Z

src/test/java/org/ays/auth/controller/AysUserEndToEndTest.java

+    @ValueSource(strings = {
+            "NOT_VERIFIED",
+            "DELETED"
+    })
+    void givenInactiveUserId_whenTryToPassivate_thenReturnUserNotActiveError(String inactiveStatus) throws Exception {


Suggested change

@ValueSource(strings = {

"NOT_VERIFIED",

"DELETED"

})

void givenInactiveUserId_whenTryToPassivate_thenReturnUserNotActiveError(String inactiveStatus) throws Exception {

@EnumSource(value = AysUserStatus.class, names = {

"NOT_VERIFIED",

"DELETED"

})

void givenInactiveUserId_whenTryToPassivate_thenReturnUserNotActiveError(AysUserStatus status) throws Exception {

agitrubard · 2025-01-27T18:15:54Z

src/test/java/org/ays/auth/service/impl/AysUserUpdateServiceImplTest.java

+    @ValueSource(strings = {
+            "NOT_VERIFIED",
+            "DELETED"
+    })
+    void givenValidId_whenUserIsNotActive_thenThrowUserNotActiveException(String inactiveStatus) {


@EnumSource(value = AysUserStatus.class, names = { "NOT_VERIFIED", "DELETED" }) void givenValidId_whenUserIsNotActive_thenThrowUserNotActiveException(AysUserStatus mockStatus) {

agitrubard · 2025-01-27T18:16:58Z

src/test/java/org/ays/auth/controller/AysUserEndToEndTest.java

+        Assertions.assertTrue(userFromDatabase.isPresent());
+        Assertions.assertEquals(userFromDatabase.get().getId(), user.getId());
+        Assertions.assertEquals(AysUserStatus.valueOf(inactiveStatus), userFromDatabase.get().getStatus());
+        Assertions.assertNull(userFromDatabase.get().getUpdatedUser());


Buraya updatedAt alanını da ekleyebiliriz

egehanasal added 8 commits January 21, 2025 23:07

AYS-660 | Error Message and Code for AysUserNotActiveAuthException …

8c0b93a

…Has Been Changed

AYS-660 | AysUserAlreadyPassiveException and Tests Are Added

2657402

Merge remote-tracking branch 'origin/main' into bugfix/AYS-660/change…

57390c4

…-user-not-active-error-code

AYS-660 | serialVersionUID is fixed

742a5bb

AYS-660 | Javadocs Have Been Fixed

b36e06e

AYS-660 | Javadocs Have Been Fixed

823853a

AYS-660 | Javadocs Have Been Fixed for AysUserAlreadyPassiveException

43a431f

AYS-660 | More more more Javadocs Have Been Fixed

24901f7

egehanasal requested review from skayikci, mgemicio, idilalemdar, filizhelvaci, yagmurbarank, hakancivelek, MenekseYuncu, sarpkan00, plnknr, ermankalpakci, valentinahalim06, gunesakkayaa and a team January 23, 2025 00:56

egehanasal self-assigned this Jan 23, 2025

egehanasal requested a review from agitrubard as a code owner January 23, 2025 00:56

egehanasal added 2 commits January 23, 2025 04:08

AYS-660 | fix.

f479348

AYS-660 | javadocs have been changed

ab6234f

idilalemdar previously approved these changes Jan 23, 2025

View reviewed changes

agitrubard requested changes Jan 26, 2025

View reviewed changes

AYS-660 | Tests and Javadocs Have Been Fixed

7a919dd

egehanasal dismissed idilalemdar’s stale review via 7a919dd January 27, 2025 13:07

AYS-660 | Test Has Been Renamed

9c901c4

agitrubard requested changes Jan 27, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

AYS-660 | Change Error Code and Message for Already Passive Users #436

AYS-660 | Change Error Code and Message for Already Passive Users #436

egehanasal commented Jan 23, 2025

agitrubard Jan 26, 2025

idilalemdar Jan 26, 2025

egehanasal Jan 27, 2025

agitrubard Jan 27, 2025

agitrubard Jan 27, 2025

agitrubard Jan 27, 2025

agitrubard Jan 27, 2025

agitrubard Jan 27, 2025

AYS-660 | Change Error Code and Message for Already Passive Users #436

Are you sure you want to change the base?

AYS-660 | Change Error Code and Message for Already Passive Users #436

Conversation

egehanasal commented Jan 23, 2025

Checklist

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment