Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(provider): eth_callMany builder #1944

Merged
merged 6 commits into from
Jan 24, 2025
Merged

Conversation

yash-atreya
Copy link
Member

Motivation

Closes #1274.
Supersedes: #1937.

Solution

Implement the eth_callMany endpoint in the Provider trait by creating an EthCallMany builder type similar to the existing EthCall builder.

PR Checklist

  • Added Tests
  • Added Documentation
  • Breaking changes

@yash-atreya yash-atreya mentioned this pull request Jan 23, 2025
3 tasks
@yash-atreya yash-atreya marked this pull request as ready for review January 23, 2025 13:24
Copy link
Member

@mattsse mattsse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm,

just one clarification wrt statecontext/blockId

crates/provider/src/provider/trait.rs Show resolved Hide resolved
Comment on lines 79 to 81
/// The builder type for an `"eth_callMany"` RPC request.
#[derive(Clone, Debug)]
pub struct EthCallManyParams<'req> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

@yash-atreya yash-atreya requested a review from mattsse January 24, 2025 06:11
@yash-atreya yash-atreya merged commit 006a668 into main Jan 24, 2025
26 checks passed
@yash-atreya yash-atreya deleted the yash/call-many-builder branch January 24, 2025 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Integrate eth_callMany support into EthCall builder
2 participants