-
-
Notifications
You must be signed in to change notification settings - Fork 218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add error message for unsupported commands/package managers #129
Conversation
Zeko369
commented
Jan 18, 2023
•
edited
Loading
edited
- Add vscode settings for default formatter / final newline (to match eslint)
- Show an error message if the current pkg manager doesn't support a command
(so it overrides users potential prettier default)
Can you explain why this is needed? Also please revert the config change, we are using eslint to format |
Currently if you select a command that's not supported by the package manager ( Example of Regarding the config, a lot of people (me included) have vscode format on save by default, which causes all projects including this one to be formatted by prettier, which isn't something everyone likes (I've read your blogpost and mostly agree for the short line length but still it helps with formatting stuff), vscodes default formatter mostly fixes indents / newlines and matches the projects eslint config, so using it on save doesn't collide with eslint. Also by default my vscode wasn't inserting new lines so why not set "project styleguides" for everyone using vscode? (since vscode with a prettier extension will format this project wrong and cause people to need to chakge the config, so why not make it work out of the box?) |
I see. I am good with the error change. About the config, it's not about opinions, you don't need to convince me as:
|
Agree 😅
Will open one later
True, how about in this PR I revert config changes and gitignore |
Hey @antfu just wanted to check in if you could review this since I want to finish the other 2 PRs and they're based on this one |