Revert "Add ability to encode and decode histogram data to portable runners (#33013)" #33761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unners (apache#33013)" This reverts commit 5bfacc9. The change caused the core SDK, the SDK harness, and the shared runners-core library to depend on Dataflow.
|
R: @johnjcasey |
|
CC: @Naireen @m-trieu @jrmccluskey I expect the forward fix will be fairly easy, just putting this code into the Dataflow runner. |
|
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
3 tasks
Abacn
approved these changes
Jan 24, 2025
|
I will let tests go green to make sure there was not a subsequent change that needs to also be included. |
|
two Dataflow legacy worker tests failed known flakiness: #28957 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 5bfacc9. The change caused the core SDK, the SDK harness, and the shared runners-core library to depend on Dataflow.
Because it depends only on the Dataflow cloud API it did not (quite/yet) introduce a cyclic dependency. We just need to correct it so that it doesn't bite us later, and to preserve Beam's overall architecture.
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.