Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.3][VL] Rename docker image name for 1.3 branch #8573

Open
wants to merge 2 commits into
base: branch-1.3
Choose a base branch
from

Conversation

zhouyuan
Copy link
Contributor

What changes were proposed in this pull request?

rename docker image for 1.3 branch

How was this patch tested?

no tests required

@github-actions github-actions bot added the INFRA label Jan 20, 2025
Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@zhouyuan zhouyuan requested a review from PHILO-HE January 21, 2025 01:11
@FelixYBW
Copy link
Contributor

@PHILO-HE
Copy link
Contributor

PHILO-HE commented Jan 22, 2025

We may also need to update this line to trigger the docker build when pushing to branch-1.3.

And do we also need to change velox_backend.yml for branch-1.3?

@zhouyuan
Copy link
Contributor Author

Do we need to update all codes here? https://github.com/search?q=repo%3Aapache%2Fincubator-gluten%20vcpkg-centos-7&type=code

Yes, we will need a new patch to make use of the new docker image

Signed-off-by: Yuan Zhou <[email protected]>
@zhztheplayer zhztheplayer changed the title [1.3][VL] rename docker image name for 1.3 branch [1.3][VL] Rename docker image name for 1.3 branch Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants