cs_regmode: Set +r if a registered channel is being recreated #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen the last user had previously left, and then someone rejoins the channel).
grawity
reviewed
May 19, 2017
| { | ||
| mychan_t *mc; | ||
|
|
||
| if (!(mc = mychan_find(c->name))) |
There was a problem hiding this comment.
Doesn't a channel_t have ->mychan?
There was a problem hiding this comment.
Also, really not a fan of assignments inside if()...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set +r if a registered channel is being recreated (e.g. when the last user had previously left, and then someone rejoins the channel).
Resolves what appears to be a simple oversight in cs_regmode: in this scenario, registered channels that previously had +r set would lose +r if the channel was ever recreated.