-
Notifications
You must be signed in to change notification settings - Fork 20
Conversation
"ctrl-alt-a": "ava:toggle" | ||
"ctrl-alt-shift-a": "ava:run", | ||
"ctrl-alt-a": "ava:run-all", | ||
"ctrl-alt-t": "ava:toggle" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should drop this shortcut. It's already covered by running. We can rather add support for pressing Esc when the pane is active to close it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Researching about this. Having some problems to detect when the pane is active. Also, the part of the application that is usually active when running tests is the editor.
I'm trying to figure this out.
Added an initial but hopefully reasonable implementation of the ESCAPE key for closing the pane. Based on: https://github.com/atom/find-and-replace/blob/master/lib/find.coffee#L78. For our case:
|
@@ -19,5 +19,5 @@ | |||
<div class="sk-child sk-bounce3"></div> | |||
</div> | |||
</div> | |||
<div id="file-header"></div> | |||
<div class="tests-container"></div> | |||
<div id='tests-groups-container' class='tests-groups-container'> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Double-quotes for HTML attributes.
….com/sindresorhus/atom-ava into support-running-all-tests-in-project
# Conflicts: # lib/test-runner-process.js
….com/sindresorhus/atom-ava into support-running-all-tests-in-project
@sindresorhus, does this look mature enough to be merged? |
group: '', | ||
currentExecution: context | ||
}; | ||
module.exports.getAssertResult = function (assert, context) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just export it directly:
module.exports = (assert, context) => {
Note arrow function too.
And just rename the file to get-assert-result.js
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, agreed!. Thank you so much @sindresorhus
Only one thing and it's ready: #18 (comment) |
@sindresorhus, as always, very grateful for all the feedback. Really appreciated. |
Found and edge case yesterday. When the user selected 'run all the files' but only one test was in the folder, the package was unable to render the results. On my side, ready to merge now @sindresorhus . |
Excellent. Works great! Thanks for your hard work on this :) |
Thank you @sindresorhus for all your feedback and support. Learning lots of things!. |
Modifications to support running all tests in project. Looking for some feedback to see if everything looks in the right direction and some implied assumptions are fine.
TerminalCommandExecutor
withBufferedNodeProcess
? #16).This feature was already started, but IMO next step should be migrate the test suite to AVA.
Related: #13