feat: Increase webcrypto compatibility #767
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richarddavison
force-pushed
the
feat/webcrypto-compat
branch
from
44ca60f to
f6a8dad
Compare
Sytten
reviewed
Jan 7, 2025
Sytten
reviewed
Jan 7, 2025
| @@ -250,6 +251,8 @@ impl ModuleDef for CryptoModule { | |||
| default.set(class_name, ctor)?; | |||
| } | |||
|
|
|||
| let crypto: Object = ctx.globals().get("crypto")?; | |||
There was a problem hiding this comment.
Lets stop doing that, it is very annoying that the user of a given module is required to call the init function just because the module eval expect a global.
There was a problem hiding this comment.
This needs to be addressed in all places. I will create a PR fixing this where we'll try getting from globals first and if not existing create a new object. This requires refactoring the object created in init to be moved to a method.
richarddavison
changed the title
richarddavison
force-pushed
the
feat/webcrypto-compat
branch
from
d2a3686 to
fb713c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue # (if available)
#184
Description of changes
Increase compatibility. More supported algorithms and methods.
TODO:
Checklist
tests/unitand/or in Rust for my feature if neededmake fixto format JS and apply Clippy auto fixesmake checktypes/directoryBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.