Maintain request header casing. #98
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Resolves #91 |
elyobo
force-pushed
the
maintain-request-header-case
branch
from
59bf2a7 to
fe1c803
Compare
|
Added tests. Note that this fix maintains the case insensitive access (to set, get and delete) but still sends the headers in the case given. |
While headers are meant to be case sensitive, many servers do not respect this. Node maintains the casing of the request headers in order to work with this and http-browserify should do likewise in order to be consistent with the node implementation. This patch maintains the casing with which the header was last set, e.g. setting header "fOo", then header "Foo" will still only send one header, but will use the final casing "Foo". This is compatible with the node implementation in https://github.com/nodejs/node/blob/85ab4a5f1281c4e1dd06450ac7bd3250326267fa/lib/_http_outgoing.js
elyobo
force-pushed
the
maintain-request-header-case
branch
from
fe1c803 to
6493496
Compare
|
@substack I notice that there hasn't been a lot of activity here recently (big queue of unmerged PRs, mainly old) - is this still maintained? |
|
Please merge or close if there's no interesting in fixing this bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While headers are meant to be case sensitive, many servers do not
respect this. Node maintains the casing of the request headers in order
to work with this and http-browserify should do likewise in order to be
consistent with the node implementation.
This patch maintains the casing with which the header was last set, e.g.
setting header "fOo", then header "Foo" will still only send one header,
but will use the final casing "Foo". This is compatible with the node implementation.